Fix #96 double start message when build is manually started

[tterrag1098]

This isn't technically tested but I think the change is pretty obvious

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[samrocketman]

I've marked this as a candidate to merge. I'll test the behavior and if it behaves as expected then I'll merge it. If not, I'll respond why.

[tterrag1098]

Just a note, I built my branch myself and installed it on my jenkins, and I could not see any of the slack options. Did something large change that I could have missed?

[samrocketman]

Seems some information was lost in the patch. Here's a snapshot of behavior before/after.

Seems there's some information lost when combining the two messages. @chrylis does this make sense or is your desire to have all contents combined?

I don't actively develop this plugin. I only maintain pull requests and releases.

[tterrag1098]

The behavior I was testing against was the behavior of the current release, which is evidently different than the behavior of the master branch. Though I don't really see the purpose of the "Starting..." message either. Isn't it a bit redundant?

[samrocketman]

The master branch significantly differs currently from the latest stable release. Therefore, it should be tested from master. It is redundant which is why this is being address by your pull request, correct? The missing information I'm referring to is "started after 2.1 sec". If you have a lot of jobs queued up and the job spent time in the Jenkins build queue then this time would be longer. So I don't think it's necessarily bad to have the information.

That's why I'm waiting on @chrylis to respond with what they originally intended. I have no qualms either way as I do not currently use the slack plugin. I maintain it for others who wish to contribute to its code base.

[samrocketman]

Since not much feedback has been received from @chrylis I'm going to go ahead and approve this pull request as a candidate to merge.

[MilesRoberts]

@samrocketman: the test you posted looks like it dumps and/or ignores the custom message from the start messaging. Am I reading that right? edit: in looking at the code it looks like it's ignoring custom message if it passes scmCause == null which is a bug from my standpoint. We rely on the custom messaging to notify build parameters and some misc other info on start

[GuiSim]

Any plans on merging this?

[samrocketman]

@MilesRoberts feel free to open an issue and perhaps a PR to address the issue.