Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom message for manually triggered builds on build start #162

Merged
merged 2 commits into from
Mar 2, 2017

Conversation

MilesRoberts
Copy link
Contributor

fixes a bug introduced in #137 that dropped custom message from the slack notification if the build wasn't kicked off by an SCM change

I tested locally and it's a pretty small change, but it could probably stand a second shakedown.

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@kmadel
Copy link
Contributor

kmadel commented Mar 14, 2016

@MilesRoberts Please fix merge conflict(s).

@kmadel kmadel added this to the slack-2.1 milestone Mar 14, 2016
@kmadel kmadel modified the milestones: slack-2.2, slack-2.1 Nov 14, 2016
@samrocketman
Copy link
Member

Please rebase this on the latest master.

@samrocketman
Copy link
Member

I plan on performing a release this weekend. If you would like this PR to be in it then please rebase/resolve.

samrocketman added a commit that referenced this pull request Mar 2, 2017
triggered builds on build start.
@samrocketman samrocketman merged commit 0f58848 into jenkinsci:master Mar 2, 2017
samrocketman added a commit that referenced this pull request Mar 2, 2017
Merge PR #162 add custom message for manually
@samrocketman
Copy link
Member

Feel free to subscribe to #296 for updates related to Slack Plugin 2.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants