Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lockable resources plugin to complement block-scoped stage #14

Merged
merged 7 commits into from
Jun 13, 2017

Conversation

svanoort
Copy link
Member

@svanoort svanoort commented Dec 7, 2016

... since we're deprecated the concurrency setting along with the classic stage type, lockable resources should be included for feature parity.

@svanoort
Copy link
Member Author

svanoort commented Dec 7, 2016

(waiting to see tests pass cleanly before submitting for review)

@jglick
Copy link
Member

jglick commented Jan 10, 2017

… org.jvnet.hudson.annotation_indexer.Index$2$1 fetch
WARNING: Failed to load org.jenkinsci.plugins.github_branch_source.GitHubSCMSource$DescriptorImpl
java.lang.NoClassDefFoundError: [Ljenkins/scm/api/SCMHeadCategory;
	at java.lang.Class.getDeclaredMethods0(Native Method)
	at java.lang.Class.privateGetDeclaredMethods(Class.java:2615)
	at java.lang.Class.getDeclaredMethods(Class.java:1860)
	at org.jvnet.hudson.annotation_indexer.Index$2$1.fetch(Index.java:102)
	at org.jvnet.hudson.annotation_indexer.Index$2$1.hasNext(Index.java:72)
	at org.jvnet.hudson.annotation_indexer.SubtypeIterator.fetch(SubtypeIterator.java:18)
	at org.jvnet.hudson.annotation_indexer.SubtypeIterator.hasNext(SubtypeIterator.java:28)
	at hudson.init.TaskMethodFinder.discoverTasks(TaskMethodFinder.java:56)
	at hudson.init.InitializerFinder.discoverTasks(InitializerFinder.java:33)
	at hudson.init.TaskMethodFinder.discoverTasks(TaskMethodFinder.java:32)
	at org.jvnet.hudson.reactor.TaskBuilder$2.discoverTasks(TaskBuilder.java:63)
	at org.jvnet.hudson.reactor.Reactor.<init>(Reactor.java:151)
	at org.jvnet.hudson.reactor.Reactor.<init>(Reactor.java:156)
	at jenkins.model.Jenkins$8.<init>(Jenkins.java:907)
	at jenkins.model.Jenkins.executeReactor(Jenkins.java:907)
	at jenkins.model.Jenkins.<init>(Jenkins.java:816)
	at hudson.model.Hudson.<init>(Hudson.java:83)
	at …

Are you going to fix this up?

@jglick
Copy link
Member

jglick commented Jan 12, 2017

Actually the error is not yours; corrected by jenkinsci/pipeline-github-lib-plugin#1 and its inclusion here.

@svanoort svanoort closed this Jan 13, 2017
@svanoort svanoort reopened this Jan 13, 2017
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps should be 1.11 now.

Likely needs to merge with #16 for tests to pass.

@jglick
Copy link
Member

jglick commented Feb 1, 2017

Please git merge master to proceed.

@svanoort
Copy link
Member Author

svanoort commented Feb 1, 2017

@jglick Should be good now?

@jglick jglick merged commit f054535 into master Jun 13, 2017
@jglick jglick deleted the lockable-resources branch June 13, 2017 22:28
@jtnord jtnord mentioned this pull request May 16, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants