Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump parent pom to 3.54 #345

Merged
merged 2 commits into from
Dec 17, 2019
Merged

Conversation

slonopotamus
Copy link
Contributor

No description provided.

@slonopotamus
Copy link
Contributor Author

slonopotamus commented Dec 17, 2019

All failed tests start a build but neither wait for completion nor abort it:

  • CpsThreadDumpActionTest#doProgramDotXml
  • CpsThreadDumpTest#parallel
  • CpsThreadDumpTest#load

I'd actually say this is a bug in JTH because it pretends as if it shut down Jenkins instance but in fact there are builds still running.

Anyway, it is better to fix tests on workflow-cps-plugin side because JTH might declare having running builds during shutdown an error.

This commit workarounds JTH not stopping builds after tests.
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dwnusbaum dwnusbaum merged commit 5db478a into jenkinsci:master Dec 17, 2019
@slonopotamus slonopotamus deleted the parent-pom-3.54 branch December 17, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants