Bump parent pom to 3.54 #170
Conversation
|
|
This commit fixes test failure with modern JTH detected by jenkinsci/jenkins-test-harness#166
This test reproduces the problem that happens in jenkinsci/lockable-resources-plugin#170
|
|
This commit fixes file descriptor leak in `LockStepHardKillTest` that is detected by newer JTH. All other dependency updates are chain reaction caused by dependency enforcer.
slonopotamus
force-pushed
the
parent-pom-3.54
branch
from
abd858d
to
21a475e
Compare
| isPaused(b1, 2, 0); | ||
|
|
||
| assertNotNull(LockableResourcesManager.get().fromName("resource1")); | ||
| j.assertBuildStatusSuccess(r1); |
There was a problem hiding this comment.
Would it help to wait some period of time for the Jenkins instance to become idle? In this example, it would wait up to 9 seconds before ending the test.
| j.assertBuildStatusSuccess(r1); | |
| j.assertBuildStatusSuccess(r1); | |
| j.waitUntilNoActivityUpTo(9001); // Allow up to 9 seconds for job to finish |
|
Answered you in jenkinsci/jenkins-test-harness#166. I haven't given up on this PR, need some more time for investigation. |
| @@ -5,7 +5,7 @@ | |||
| <parent> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>plugin</artifactId> | |||
| <version>3.47</version> | |||
| <version>3.54</version> | |||
There was a problem hiding this comment.
Even:
| <version>3.54</version> | |
| <version>3.57</version> |
TobiX
added
chore
|
@slonopotamus Sorry for trampling over this pull request in master 😅 - Do you still want to get this merged? The updates to test cases look interesting at least... |
|
I actually forgot why I touched so many dependencies. Possibly this was an effort to fix Need to restart it from scratch. |
No description provided.