Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcuts to save and load #13

Closed
Bartleby2718 opened this issue Jun 29, 2019 · 5 comments
Closed

Add shortcuts to save and load #13

Bartleby2718 opened this issue Jun 29, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Bartleby2718
Copy link
Collaborator

https://developer.chrome.com/extensions/commands#usage

@Bartleby2718 Bartleby2718 added the enhancement New feature or request label Jun 29, 2019
@Bartleby2718 Bartleby2718 added this to the Minimum Viable Product milestone Jun 29, 2019
@Bartleby2718 Bartleby2718 self-assigned this Jun 29, 2019
@Bartleby2718
Copy link
Collaborator Author

This issue wasn't solved in the commit. Must have deleted the code when I made a commit.

@Bartleby2718 Bartleby2718 reopened this Jul 2, 2019
@Bartleby2718 Bartleby2718 removed this from the Minimum Viable Product milestone Jul 2, 2019
@Bartleby2718
Copy link
Collaborator Author

Memo

https://itnext.io/create-chrome-extension-with-reactjs-using-inject-page-strategy-137650de1f39
3. Injecting a React app to page as content script

@Bartleby2718 Bartleby2718 removed their assignment Jul 5, 2019
@Bartleby2718 Bartleby2718 added the wontfix This will not be worked on label Jul 5, 2019
@Bartleby2718
Copy link
Collaborator Author

Bartleby2718 commented Jul 5, 2019

"background": {
    "scripts": ["background.js"],
    "persistent": false
  },
chrome.commands.onCommand.addListener(function (command) {
    if (command = 'save') {
        saveClicked();
    }
    else if (command = 'load') {
        loadClicked();
    }
});

@Bartleby2718
Copy link
Collaborator Author

Test on Macs before releasing.

@jeongm-in
Copy link
Owner

@jeongm-in

@Bartleby2718 Bartleby2718 reopened this Jul 8, 2019
@Bartleby2718 Bartleby2718 removed wontfix This will not be worked on labels Jul 8, 2019
@Bartleby2718 Bartleby2718 self-assigned this Jul 8, 2019
@Bartleby2718 Bartleby2718 added this to the Minimum Viable Product milestone Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants