-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create background script #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bartleby2718
added
enhancement
New feature or request
refactoring
Altering the internal--but not external--behavior
labels
Jul 8, 2019
jeongm-in
reviewed
Jul 8, 2019
jeongm-in
reviewed
Jul 8, 2019
jeongm-in
reviewed
Jul 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Additional bundling
- Need clarification on "works better." Does it mean performance improvement? Build time improvement?
- On install folder creation
- confirmed folder is correctly created on install.
- new folder is created in whatever occasion it is gone.
- Shortcut
- confirmed shortcuts are functional.
- also tested on Ubuntu 18.04.2 LTS with latest Google Chrome stable 75.0.3770.100-1, although it doesn't mean much.
- will test on OSX environment later tonight.
2, 3. Thank you for the testings. |
Shortcut works fine as expected in OSX. Approve merge into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Additional bundling through
webpack-cli
#43react-scripts build
) is over,webpack
is used to bundlenode_modules
andbackground.ts
. The downside is that it takes twice as long as the previous build.tsconfig.other.json
--to transpile TS files because it requires thatnoEmit
be false. Still, I minimized the difference by extending the existingtsconfig.json
. Simplify tsconfig.other.json through inheritance #68ts-loader
because it somehow works better than the existingawesome-typescript-loader
.2. Create folder upon installation #43
saveClicked
orloadClicked
because they all check the existence and the validity ofwebmarkFolderId
.3. Keyboard shortcuts #13
4. Refactorings #63 #66 #67
utils.ts
, it is now very clear what happens in the popup (index.tsx
).