Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump alpine version to 3.17 #495

Closed
wants to merge 1 commit into from

Conversation

biran4454
Copy link

@biran4454 biran4454 commented Oct 25, 2023

Prevent docker build error (armv8) as Golang haven't released an alpine 3.15 version on 1.20.

@turbcool
Copy link

turbcool commented Nov 4, 2023

Tested this on an arm64v8 device. The image builds successfully (following the README instructions).

@mark2185
Copy link
Contributor

mark2185 commented Nov 4, 2023

This PR should close #497 .

@cwong-archy
Copy link

cwong-archy commented Nov 28, 2023

i am having trouble building with this change -

──── git diff
diff --git a/Dockerfile b/Dockerfile
index 9719593..502093c 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,5 +1,5 @@
 ARG BASE_IMAGE_BUILDER=golang
-ARG ALPINE_VERSION=3.15
+ARG ALPINE_VERSION=3.17
 ARG GO_VERSION=1.20

 FROM ${BASE_IMAGE_BUILDER}:${GO_VERSION}-alpine${ALPINE_VERSION} AS builder
──── docker build -t lazyteam/lazydocker --build-arg BASE_IMAGE_BUILDER=arm64v8/golang --build-arg GOARCH=arm64 https://github.com/jesseduffield/lazydocker.git
[+] Building 5.3s (3/3) FINISHED                                                                                                                                                                     docker:default
 => CACHED [internal] load git source https://github.com/jesseduffield/lazydocker.git                                                                                                                          3.6s
 => ERROR [internal] load metadata for docker.io/arm64v8/golang:1.20-alpine3.15                                                                                                                                1.5s
 => [auth] arm64v8/golang:pull token for registry-1.docker.io                                                                                                                                                  0.0s
------
 > [internal] load metadata for docker.io/arm64v8/golang:1.20-alpine3.15:
------
Dockerfile:19
--------------------
  17 |         -X main.buildSource=Docker"
  18 |
  19 | >>> FROM ${BASE_IMAGE_BUILDER}:${GO_VERSION}-alpine${ALPINE_VERSION} AS docker-builder
  20 |     ARG GOARCH=amd64
  21 |     ARG GOARM
--------------------
ERROR: failed to solve: arm64v8/golang:1.20-alpine3.15: docker.io/arm64v8/golang:1.20-alpine3.15: not found

am i doing something wrong? i dont see any reference to 3.15 anywhere in the repo after the change but some how it still think its looking for alpine3.15 ...

note: this is on a raspberry pi so i am not sure how the argument would be -

──── dpkg --print-architecture
armhf

@biran4454
Copy link
Author

──── docker build -t lazyteam/lazydocker --build-arg BASE_IMAGE_BUILDER=arm64v8/golang --build-arg GOARCH=arm64 https://github.com/jesseduffield/lazydocker.git

Looks like you're still building from the main git repo rather than the forked / local one.

@cwong-archy
Copy link

──── docker build -t lazyteam/lazydocker --build-arg BASE_IMAGE_BUILDER=arm64v8/golang --build-arg GOARCH=arm64 https://github.com/jesseduffield/lazydocker.git

Looks like you're still building from the main git repo rather than the forked / local one.

thank you!!! good catch!!! 😅

@cwong-archy
Copy link

──── docker build -t lazyteam/lazydocker --build-arg BASE_IMAGE_BUILDER=arm64v8/golang --build-arg GOARCH=arm64 https://github.com/jesseduffield/lazydocker.git

Looks like you're still building from the main git repo rather than the forked / local one.

thank you!!! good catch!!! 😅

@biran4454 appreciate the help. finally got it built. for raspberry pi (hopefully this will help others), i had to pass these values during build -

docker build -t lazyteam/lazydocker --build-arg BASE_IMAGE_BUILDER=arm32v7/golang --build-arg GOARCH=arm .

@jesseduffield
Copy link
Owner

This is obsoleted by #561, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants