Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cleared the describe.skip Behaviour #12164

Closed
wants to merge 2 commits into from
Closed

Fix: Cleared the describe.skip Behaviour #12164

wants to merge 2 commits into from

Conversation

Biki-das
Copy link
Contributor

@Biki-das Biki-das commented Dec 20, 2021

The current documentation for describe.skip was misleading: its tests or setup functions are not run, but any other statements are run.

@Biki-das Biki-das changed the title Fix: Added the line denoting test might run Fix: Cleared the describe.skip Behaviour Dec 20, 2021
@Biki-das
Copy link
Contributor Author

@SimenB ping

@SimenB
Copy link
Member

SimenB commented Feb 5, 2022

The fork is deleted, so I'm not allowed to comment inline. There are some changes I'd like to suggest 😀 Can you re-push the branch or something?

@Biki-das
Copy link
Contributor Author

Biki-das commented Feb 7, 2022

@SimenB sorry but i deleted the main repo long back but could you suggest me the changes here and i shall just pull a fresh PR reffering this one

@SimenB
Copy link
Member

SimenB commented Feb 7, 2022

just open a new one and I'll take it there 🙂

@SimenB SimenB closed this Feb 7, 2022
@Biki-das
Copy link
Contributor Author

Biki-das commented Feb 8, 2022

just open a new one and I'll take it there 🙂

Sure

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants