Doc- clarify the describe.skip behaviour
#12332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #12332 +/- ##
==========================================
- Coverage 67.25% 67.25% -0.01%
==========================================
Files 330 330
Lines 17354 17354
Branches 5073 5073
==========================================
- Hits 11672 11671 -1
- Misses 5650 5651 +1
Partials 32 32
Continue to review full report at Codecov.
|
|
@SimenB waiting for your thoughts |
SimenB
approved these changes
Feb 13, 2022
| @@ -398,7 +398,7 @@ test('will not be ran', () => { | |||
|
|
|||
| Also under the alias: `xdescribe(name, fn)` | |||
|
|
|||
| You can use `describe.skip` if you do not want to run a particular describe block: | |||
| You can use `describe.skip` if you do not want to run the tests of a particular described block: | |||
There was a problem hiding this comment.
Suggested change
| You can use `describe.skip` if you do not want to run the tests of a particular described block: | |
| You can use `describe.skip` if you do not want to run the tests of a particular `describe` block: |
| @@ -416,7 +416,7 @@ describe.skip('my other beverage', () => { | |||
| }); | |||
| ``` | |||
|
|
|||
| Using `describe.skip` is often a cleaner alternative to temporarily commenting out a chunk of tests. | |||
| Using `describe.skip` is often a cleaner alternative to temporarily commenting out a chunk of tests. Beware that the `describe` block will still be run. If you have some setup that should be skipped, do it in a `beforeAll` or `beforeEach` block. | |||
There was a problem hiding this comment.
Suggested change
| Using `describe.skip` is often a cleaner alternative to temporarily commenting out a chunk of tests. Beware that the `describe` block will still be run. If you have some setup that should be skipped, do it in a `beforeAll` or `beforeEach` block. | |
| Using `describe.skip` is often a cleaner alternative to temporarily commenting out a chunk of tests. Beware that the `describe` block will still run. If you have some setup that also should be skipped, do it in a `beforeAll` or `beforeEach` block. |
|
closing this one @SimenB as i pulled a new one for this |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SimenB in reference to #12164, you said you had some changes in mind, so i just pushed one change in the main doc,
lets discuss the changes and finally put the rest in other docs and complete the PR