Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@jest/reporters): do not transform file paths into hyperlinks #13399

Merged
merged 2 commits into from
Oct 7, 2022
Merged

fix(@jest/reporters): do not transform file paths into hyperlinks #13399

merged 2 commits into from
Oct 7, 2022

Conversation

mrazauskas
Copy link
Contributor

Reverts #8980

Summary

There was a plan to revert the above mentioned PR already (see #8980 (comment)) and there was a PR trying to do so #9294. The reasons are well explained there

I would like to add that VS Code was added to supports-hyperlinks list recently. Hence the issue will be visible for much more users now.

This change could look breaking and I could agree with that. In the other hand, this is mostly aesthetic change. Just to be sure, I was trying out few terminal apps (e.g. iTerm). Only the underlines get removed, but cmd/ctrl + click works as expected.

Also note that current implementation lacks consistency. Paths in the stack trace are not underlined, as well as paths with RUNS:

Screenshot 2022-10-07 at 13 11 13

(This screenshot still looks alright. In realty readability is worse.)

Test plan

Green CI.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me 👍

@SimenB SimenB merged commit 7e55a0c into jestjs:main Oct 7, 2022
@mrazauskas mrazauskas deleted the fix-revert-file-paths-hyperlinks branch October 7, 2022 16:16
@SimenB
Copy link
Member

SimenB commented Oct 14, 2022

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants