Fully remove weak and check only in runtime #5252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5252 +/- ##
=======================================
Coverage 61.14% 61.14%
=======================================
Files 203 203
Lines 6843 6843
Branches 3 4 +1
=======================================
Hits 4184 4184
Misses 2658 2658
Partials 1 1
Continue to review full report at Codecov.
|
SimenB
approved these changes
Jan 8, 2018
| @@ -37,15 +37,16 @@ export default class { | |||
| let weak; | |||
|
|
|||
| try { | |||
| // eslint-disable-next-line | |||
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully remove the module from the package, and leave the developer willing to use it to install it on the parent package. This way we will avoid crashing or waiting for a timeout if the machine cannot compile it or has no internet connection.
Keeping it as an optional dependency means that the network timeout has to be triggered; which can take a lot of time depending on the setup.