-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify conditional test logic #6314
Conversation
we should also do |
Nice! I've all but 3 integration tests pass on windows in #6310, can we merge that first? |
Codecov Report
@@ Coverage Diff @@
## master #6314 +/- ##
=======================================
Coverage 63.64% 63.64%
=======================================
Files 227 227
Lines 8638 8638
Branches 3 3
=======================================
Hits 5498 5498
Misses 3139 3139
Partials 1 1 Continue to review full report at Codecov.
|
@SimenB Fine by me. I'm happy to rebase. |
Awesome, I'll merge as soon as appveyor is green (any minute now) |
Done! (and oh god, what a conflict list!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff
This makes the logic a bit easier to read, but also lets us skip some integration tests on Jasmine, which will be needed as we make Circus stricter.
Waiting with #6315 until this PR is merged :) |
Thanks @thymikee. Just waiting on CI. Will you merge for me once/if it passes? |
💚 |
* upstream/master: Unify conditional test logic (jestjs#6314)
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This makes the logic a bit easier to read, but also lets us skip some
integration tests on Jasmine, which will be needed as we make Circus
stricter.
@aaronabramov @rickhanlonii