normalize icons and slashes across OSes #6310
Conversation
SimenB
force-pushed
the
windows
branch
4 times, most recently
from
92c8f6b
to
021151e
Compare
SimenB
changed the title
|
Note that this changes output on windows machines (for the better, IMO). Old: New: |
Codecov Report
@@ Coverage Diff @@
## master #6310 +/- ##
==========================================
- Coverage 63.65% 63.64% -0.01%
==========================================
Files 227 227
Lines 8637 8638 +1
Branches 3 3
==========================================
Hits 5498 5498
- Misses 3138 3139 +1
Partials 1 1
Continue to review full report at Codecov.
|
|
@cpojer thoughts? |
|
Nice!
…________________________________
From: Simen Bekkhus <notifications@github.com>
Sent: Sunday, May 27, 2018 4:25:21 PM
To: facebook/jest
Cc: Christoph Nakazawa; Mention
Subject: Re: [facebook/jest] normalize icons and slashes across OSes (#6310)
@cpojer<https://github.com/cpojer> thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#6310 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAA0KJbKpVsRTNgu87FauYUz24u1Zb5Tks5t2sVhgaJpZM4UPQfu>.
|
| @@ -76,7 +76,7 @@ export const formatTestPath = ( | |||
| testPath: Path, | |||
| ) => { | |||
| const {dirname, basename} = relativePath(config, testPath); | |||
| return chalk.dim(dirname + path.sep) + chalk.bold(basename); | |||
| return slash(chalk.dim(dirname + path.sep) + chalk.bold(basename)); | |||
There was a problem hiding this comment.
Anybody with a Windows computer can confirm you can Ctrl+Click to get to test location? If it actually ever worked earlier of course
There was a problem hiding this comment.
didn't work from cmd at least (before or after). I didn't test in e.g. git bash or commandr (or what it's called, it's been years since I developed on windows)
There was a problem hiding this comment.
Looks like this should work with VSCode and terminals like git bash already use such paths. microsoft/vscode#27082
|
Mind adding a changelog entry? |
😅 been too much hacking lately, I've forgotten all about that |
|
#yolo |
* upstream/master: normalize icons and slashes across OSes (jestjs#6310) fix: toMatchObject throws TypeError when a source property is null (jestjs#6313)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This PR uses
slashin order for filepaths in test headings andconsoletraces in output to be consistent across OSes.It also normalizes the icons in the integration tests.
Related to #3121
Test plan
Green CI even though we're activating 30 new integration tests on windows