Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to k8s.io/api/admissionregistration/v1 #30

Closed
invidian opened this issue Apr 27, 2021 · 5 comments
Closed

Update to k8s.io/api/admissionregistration/v1 #30

invidian opened this issue Apr 27, 2021 · 5 comments

Comments

@invidian
Copy link

k8s.io/api/admissionregistration/v1beta1 is deprecated since Kubernetes 1.16+ and will be removed in 1.22+. Code should be updated to use new API types.

@jonkerj
Copy link

jonkerj commented Aug 26, 2021

This bug causes kube-webhook-certgen to bail/fail on Kubernetes 1.22:

jorik@argon:$ kubectl logs -n monitoring kps-admission-patch--1-mtzsk
W0826 10:16:43.550360       1 client_config.go:608] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
{"level":"info","msg":"patching webhook configurations 'kps-admission' mutating=true, validating=true, failurePolicy=Fail","source":"k8s/k8s.go:39","time":"2021-08-26T10:16:43Z"}
{"err":"the server could not find the requested resource","level":"fatal","msg":"failed getting validating webhook","source":"k8s/k8s.go:48","time":"2021-08-26T10:16:43Z"}

@brandond
Copy link

brandond commented Sep 30, 2021

For anyone finding this issue, as per @vsliouniaev

I no longer have access rights to this repository and it is no longer being maintained by the company. There is already a fork of this in the ingress-nginx repo, which has updated APIs and is hosted on GCR: https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/values.yaml#L569

michaelbeaumont added a commit to michaelbeaumont/gateway-api that referenced this issue Jan 13, 2022
The patch fails on k8s v1.22, see jet/kube-webhook-certgen#30. The jet
upstream is no longer supported. It was forked and moved into kubernetes/ingress-nginx
and is now published at k8s.gcr.io/ingress-nginx.

See also https://github.com/kubernetes/k8s.io/blob/main/k8s.gcr.io/images/k8s-staging-ingress-nginx/images.yaml
michaelbeaumont added a commit to michaelbeaumont/gateway-api that referenced this issue Jan 13, 2022
The patch fails on k8s v1.22, see jet/kube-webhook-certgen#30. The jet
upstream is no longer supported. It was forked and moved into kubernetes/ingress-nginx
and is now published at k8s.gcr.io/ingress-nginx.

See also https://github.com/kubernetes/k8s.io/blob/main/k8s.gcr.io/images/k8s-staging-ingress-nginx/images.yaml
michaelbeaumont added a commit to michaelbeaumont/gateway-api that referenced this issue Jan 13, 2022
The admission webhook certificate generation fails on k8s v1.22, see jet/kube-webhook-certgen#30. The jet
upstream is no longer supported. It was forked and moved into kubernetes/ingress-nginx
and is now published at k8s.gcr.io/ingress-nginx.

See also https://github.com/kubernetes/k8s.io/blob/main/k8s.gcr.io/images/k8s-staging-ingress-nginx/images.yaml
michaelbeaumont added a commit to michaelbeaumont/gateway-api that referenced this issue Jan 13, 2022
The admission webhook certificate generation fails on k8s v1.22, see jet/kube-webhook-certgen#30. The jet
upstream is no longer supported. It was forked and moved into kubernetes/ingress-nginx
and is now published at k8s.gcr.io/ingress-nginx.

See also https://github.com/kubernetes/k8s.io/blob/main/k8s.gcr.io/images/k8s-staging-ingress-nginx/images.yaml

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit to michaelbeaumont/gateway-api that referenced this issue Jan 13, 2022
The admission webhook certificate generation fails on k8s v1.22, see jet/kube-webhook-certgen#30.
The jet upstream is no longer supported.
It was forked, moved into kubernetes/ingress-nginx, fixed
and is now published at k8s.gcr.io/ingress-nginx.

See also https://github.com/kubernetes/k8s.io/blob/main/k8s.gcr.io/images/k8s-staging-ingress-nginx/images.yaml

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@ousiax
Copy link

ousiax commented Feb 8, 2022

please try to use k8s.gcr.io/ingress-nginx/kube-webhook-certgen:v1.1.1 instead.

@invidian
Copy link
Author

invidian commented Feb 8, 2022

I'll close this issue as k8s.gcr.io/ingress-nginx/kube-webhook-certgen is now likely considered upstream.

@stigok
Copy link

stigok commented Apr 6, 2022

I'll lose this issue as k8s.gcr.io/ingress-nginx/kube-webhook-certgen is now likely considered upstream.

I think this issue should be left open for exactly this reason.

robscott pushed a commit to robscott/gateway-api that referenced this issue Apr 21, 2022
The admission webhook certificate generation fails on k8s v1.22, see jet/kube-webhook-certgen#30.
The jet upstream is no longer supported.
It was forked, moved into kubernetes/ingress-nginx, fixed
and is now published at k8s.gcr.io/ingress-nginx.

See also https://github.com/kubernetes/k8s.io/blob/main/k8s.gcr.io/images/k8s-staging-ingress-nginx/images.yaml

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants