Bump default Kubernetes version to v1.22.1 and update addons to with new API (ingress, gcpauth, olm and cilium) #12325

prezha · 2021-08-22T03:20:25Z

fixes #12299

tldr: with this pr, ingress, gcpauth, olm and cilium should also work with the latest k8s v1.22+

there are still a lot of moving parts there and i'll try to document them here

changes and notes:

enable support for k8s v1.22.1 (set as new DefaultKubernetesVersion) - covers also bump default/newest kubernetes versions #12283
new apis and images for ingress will be used with k8s v1.19+
- successfully tested locally v1.19.0..v1.22.1 with docker and kvm
- works without removing ValidatingWebhookConfiguration - as many suggested as a workaround to use atm
should stay backwards compatible with older k8s versions
- i couldn't test this directly locally as the build from the current master would not run minikube with k8s earlier than v1.19 - even w/o ingress - but that's a separate issue i guess
- successfully tested backwards compatibility by simulating - ie, changing the code so that it would use older ingress deployment yaml format and older images for v1.19.0..v1.21.0
restructured and updated ingress deployment yaml template so that it's more easily maintainable and comparable to the upstream (ref: https://github.com/kubernetes/ingress-nginx/tree/main/deploy/static/provider)

background - deprecation announcement: Updating NGINX-Ingress to use the stable Ingress API

Use ingress v1 API (Use ingress v1 API ingress-nginx#7145)
- Drop v1beta1 from ingress nginx (Drop v1beta1 from ingress nginx ingress-nginx#7156)
- Things to do before the v1 version is released (Things to do before the v1 version is released ingress-nginx#7398)
- docs for migration of ingress resources in K8s v1.22 and beyond (docs for migration of ingress resources in K8s v1.22 and beyond ingress-nginx#7441)

many issues and conversations around this breaking change, kubernetes/ingress-nginx#7448 is a useful read

NGINX Ingress Controller (aka ingress-nginx/controller)

latest stable release v0.49.0 does not work with k8s v1.22+, v1.0.0 Beta 3 works but only with k8s v1.19+ (https://github.com/kubernetes/ingress-nginx/releases/tag/controller-v1.0.0-beta.3) introducing breaking changes: https://github.com/kubernetes/ingress-nginx/#support-versions-table

Kubernetes webhook certificate generator and patcher (aka kube-webhook-certgen)

so far, jet/kube-webhook-certgen was used (https://github.com/jet/kube-webhook-certgen), but it's not yet updated to work with k8s v1.22+, ie,
docker.io/jettech/kube-webhook-certgen:v1.5.1 does not work, neither the newer docker.io/jettech/kube-webhook-certgen:v1.5.2 (https://hub.docker.com/layers/jettech/kube-webhook-certgen/v1.5.2/images/sha256-4709d4110f667ba19875d17a23c04ab016c03ae6493d456fb41d942854b23ac1?context=explore)

there's an open issue (kubernetes/ingress-nginx#7418) and pr (jet/kube-webhook-certgen#30) that could address that at some point

in the meantime, upstream already forked this repo and adapted it (https://github.com/kubernetes/ingress-nginx/tree/main/images/kube-webhook-certgen):

We moved it here so we can change/update the Kubernetes APIs, and we are really thankful to the original creators.

but https://github.com/kubernetes/ingress-nginx/tree/main/images states:

Only the nginx image is meant to be published. Other images are used as examples for a feature of the ingress controller or to run e2e tests

so, i manually built the kube-webhook-certgen image from the upstream repo (https://github.com/kubernetes/ingress-nginx/blob/main/images/kube-webhook-certgen/Makefile => https://hub.docker.com/repository/docker/prezha/kube-webhook-certgen), but then i've found the "official" image that can be used - k8s.gcr.io/ingress-nginx/kube-webhook-certgen:v1.0@sha256:f3b6b39a6062328c095337b4cadcefd1612348fdd5190b1dcbcb9b9e90bd8068:
https://github.com/kubernetes/ingress-nginx/blob/557604f4ef526f7755d36089b617bc7686c389f9/deploy/static/provider/kind/deploy.yaml#L612
that is:
https://github.com/kubernetes/ingress-nginx/blob/557604f4ef526f7755d36089b617bc7686c389f9/deploy/static/provider/kind/deploy.yaml#L660

examples

just-ingress@docker test:

❯ env TEST_ARGS="-minikube-start-args='--driver=docker' -test.run TestAddons --cleanup=false" make integration
go test -ldflags="-X k8s.io/minikube/pkg/version.version=v1.22.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.22.0-1628974786-12268 -X k8s.io/minikube/pkg/version.gitCommitID="69d5d34eeb4d5f3ad963c544773dd088d6550821-dirty" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v5" -v -test.timeout=90m ./test/integration --tags="integration " -minikube-start-args='--driver=docker' -test.run TestAddons --cleanup=false 2>&1 | tee "./out/testout_69d5d34ee.txt"
Found 16 cores, limiting parallelism with --test.parallel=9
=== RUN   TestAddons
=== RUN   TestAddons/Setup
    addons_test.go:80: (dbg) Run:  out/minikube start -p addons-20210822033320-3217571 --wait=true --memory=4000 --alsologtostderr --driver=docker --addons=ingress
    addons_test.go:80: (dbg) Done: out/minikube start -p addons-20210822033320-3217571 --wait=true --memory=4000 --alsologtostderr --driver=docker --addons=ingress: (1m7.078556595s)
=== RUN   TestAddons/parallel
=== RUN   TestAddons/parallel/Ingress
=== PAUSE TestAddons/parallel/Ingress
=== CONT  TestAddons/parallel/Ingress
    addons_test.go:170: (dbg) Run:  kubectl --context addons-20210822033320-3217571 wait --for=condition=ready --namespace=ingress-nginx pod --selector=app.kubernetes.io/component=controller --timeout=90s
    addons_test.go:170: (dbg) Done: kubectl --context addons-20210822033320-3217571 wait --for=condition=ready --namespace=ingress-nginx pod --selector=app.kubernetes.io/component=controller --timeout=90s: (13.875082612s)
    addons_test.go:177: (dbg) Run:  kubectl --context addons-20210822033320-3217571 replace --force -f testdata/nginx-ingv1.yaml
    addons_test.go:190: (dbg) Run:  kubectl --context addons-20210822033320-3217571 replace --force -f testdata/nginx-pod-svc.yaml
    addons_test.go:195: (dbg) TestAddons/parallel/Ingress: waiting 4m0s for pods matching "run=nginx" in namespace "default" ...
    helpers_test.go:343: "nginx" [a150e166-bb61-4d0c-a5d7-bb5d88311075] Pending / Ready:ContainersNotReady (containers with unready status: [nginx]) / ContainersReady:ContainersNotReady (containers with unready status: [nginx])
    helpers_test.go:343: "nginx" [a150e166-bb61-4d0c-a5d7-bb5d88311075] Running
    addons_test.go:195: (dbg) TestAddons/parallel/Ingress: run=nginx healthy within 12.015628991s
    addons_test.go:215: (dbg) Run:  out/minikube -p addons-20210822033320-3217571 ssh "curl -s http://127.0.0.1/ -H 'Host: nginx.example.com'"
    addons_test.go:234: (dbg) Run:  out/minikube -p addons-20210822033320-3217571 addons disable ingress --alsologtostderr -v=1
    addons_test.go:234: (dbg) Done: out/minikube -p addons-20210822033320-3217571 addons disable ingress --alsologtostderr -v=1: (28.727228701s)
=== CONT  TestAddons
    helpers_test.go:184: skipping cleanup of addons-20210822033320-3217571 (--cleanup=false)
--- PASS: TestAddons (122.52s)
    --- PASS: TestAddons/Setup (67.28s)
    --- PASS: TestAddons/parallel (0.00s)
        --- PASS: TestAddons/parallel/Ingress (55.25s)
PASS
Tests completed in 2m2.522589658s (result code 0)
ok      k8s.io/minikube/test/integration        122.560s

just-ingress@kvm test:

❯ env TEST_ARGS="-minikube-start-args='--driver=kvm' -test.run TestAddons --cleanup=false" make integration
go test -ldflags="-X k8s.io/minikube/pkg/version.version=v1.22.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.22.0-1628974786-12268 -X k8s.io/minikube/pkg/version.gitCommitID="69d5d34eeb4d5f3ad963c544773dd088d6550821-dirty" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v5" -v -test.timeout=90m ./test/integration --tags="integration " -minikube-start-args='--driver=kvm' -test.run TestAddons --cleanup=false 2>&1 | tee "./out/testout_69d5d34ee.txt"
Found 16 cores, limiting parallelism with --test.parallel=9
=== RUN   TestAddons
=== RUN   TestAddons/Setup
    addons_test.go:80: (dbg) Run:  out/minikube start -p addons-20210822013905-3004952 --wait=true --memory=4000 --alsologtostderr --driver=kvm --addons=ingress
    addons_test.go:80: (dbg) Done: out/minikube start -p addons-20210822013905-3004952 --wait=true --memory=4000 --alsologtostderr --driver=kvm --addons=ingress: (2m2.902251022s)
=== RUN   TestAddons/parallel
=== RUN   TestAddons/parallel/Ingress
=== PAUSE TestAddons/parallel/Ingress
=== CONT  TestAddons/parallel/Ingress
    addons_test.go:170: (dbg) Run:  kubectl --context addons-20210822013905-3004952 wait --for=condition=ready --namespace=ingress-nginx pod --selector=app.kubernetes.io/component=controller --timeout=90s
    addons_test.go:170: (dbg) Done: kubectl --context addons-20210822013905-3004952 wait --for=condition=ready --namespace=ingress-nginx pod --selector=app.kubernetes.io/component=controller --timeout=90s: (10.538721881s)
    addons_test.go:177: (dbg) Run:  kubectl --context addons-20210822013905-3004952 replace --force -f testdata/nginx-ingv1.yaml
    addons_test.go:190: (dbg) Run:  kubectl --context addons-20210822013905-3004952 replace --force -f testdata/nginx-pod-svc.yaml
    addons_test.go:195: (dbg) TestAddons/parallel/Ingress: waiting 4m0s for pods matching "run=nginx" in namespace "default" ...
    helpers_test.go:343: "nginx" [6246bd01-9540-4af8-ab6b-24aad0fdddd8] Pending / Ready:ContainersNotReady (containers with unready status: [nginx]) / ContainersReady:ContainersNotReady (containers with unready status: [nginx])
    helpers_test.go:343: "nginx" [6246bd01-9540-4af8-ab6b-24aad0fdddd8] Running
    addons_test.go:195: (dbg) TestAddons/parallel/Ingress: run=nginx healthy within 15.034188076s
    addons_test.go:215: (dbg) Run:  out/minikube -p addons-20210822013905-3004952 ssh "curl -s http://127.0.0.1/ -H 'Host: nginx.example.com'"
=== CONT  TestAddons
    helpers_test.go:184: skipping cleanup of addons-20210822013905-3004952 (--cleanup=false)
--- PASS: TestAddons (149.03s)
    --- PASS: TestAddons/Setup (122.96s)
    --- PASS: TestAddons/parallel (0.00s)
        --- PASS: TestAddons/parallel/Ingress (26.08s)
PASS
Tests completed in 2m29.033760085s (result code 0)
ok      k8s.io/minikube/test/integration        149.060s

full test (filtered):

TestAddons/parallel/Ingress:
13          addons_test.go:170: (dbg) Run:  kubectl --context addons-20210822033320-3217571 wait --for=condition=ready --namespace=ingress-nginx pod --selector=app.kubernetes.io/component=controller --timeout=90s
14          addons_test.go:170: (dbg) Done: kubectl --context addons-20210822033320-3217571 wait --for=condition=ready --namespace=ingress-nginx pod --selector=app.kubernetes.io/component=controller --timeout=90s: (13.875082612s)
15          addons_test.go:177: (dbg) Run:  kubectl --context addons-20210822033320-3217571 replace --force -f testdata/nginx-ingv1.yaml
16          addons_test.go:190: (dbg) Run:  kubectl --context addons-20210822033320-3217571 replace --force -f testdata/nginx-pod-svc.yaml
17          addons_test.go:195: (dbg) TestAddons/parallel/Ingress: waiting 4m0s for pods matching "run=nginx" in namespace "default" ...
18          helpers_test.go:343: "nginx" [a150e166-bb61-4d0c-a5d7-bb5d88311075] Pending / Ready:ContainersNotReady (containers with unready status: [nginx]) / ContainersReady:ContainersNotReady (containers with unready status: [nginx])
19          helpers_test.go:343: "nginx" [a150e166-bb61-4d0c-a5d7-bb5d88311075] Running
20          addons_test.go:195: (dbg) TestAddons/parallel/Ingress: run=nginx healthy within 12.015628991s
21          addons_test.go:215: (dbg) Run:  out/minikube -p addons-20210822033320-3217571 ssh "curl -s http://127.0.0.1/ -H 'Host: nginx.example.com'"
22          addons_test.go:234: (dbg) Run:  out/minikube -p addons-20210822033320-3217571 addons disable ingress --alsologtostderr -v=1
23          addons_test.go:234: (dbg) Done: out/minikube -p addons-20210822033320-3217571 addons disable ingress --alsologtostderr -v=1: (28.727228701s)
68          addons_test.go:169: (dbg) Run:  kubectl --context addons-20210822034609-3237971 wait --for=condition=ready --namespace=ingress-nginx pod --selector=app.kubernetes.io/component=controller --timeout=90s
2708        addons_test.go:169: (dbg) Done: kubectl --context addons-20210822034609-3237971 wait --for=condition=ready --namespace=ingress-nginx pod --selector=app.kubernetes.io/component=controller --timeout=90s: (15.722536526s)
2709        addons_test.go:176: (dbg) Run:  kubectl --context addons-20210822034609-3237971 replace --force -f testdata/nginx-ingv1.yaml
2710        addons_test.go:189: (dbg) Run:  kubectl --context addons-20210822034609-3237971 replace --force -f testdata/nginx-pod-svc.yaml
2711        addons_test.go:194: (dbg) TestAddons/parallel/Ingress: waiting 4m0s for pods matching "run=nginx" in namespace "default" ...
2712        helpers_test.go:343: "nginx" [2053ce1b-96de-452d-ad52-8dd6387d3b38] Pending / Ready:ContainersNotReady (containers with unready status: [nginx]) / ContainersReady:ContainersNotReady (containers with unready status: [nginx])
2742        helpers_test.go:343: "nginx" [2053ce1b-96de-452d-ad52-8dd6387d3b38] Running
2752        addons_test.go:194: (dbg) TestAddons/parallel/Ingress: run=nginx healthy within 14.004000665s
2753        addons_test.go:214: (dbg) Run:  out/minikube -p addons-20210822034609-3237971 ssh "curl -s http://127.0.0.1/ -H 'Host: nginx.example.com'"
2754        addons_test.go:233: (dbg) Run:  out/minikube -p addons-20210822034609-3237971 addons disable ingress --alsologtostderr -v=1
2771        addons_test.go:233: (dbg) Done: out/minikube -p addons-20210822034609-3237971 addons disable ingress --alsologtostderr -v=1: (28.602694275s)

simulated backwards compatibility test with k8s v1.19.0 and old deployment (apis) and images for ingress:

❯ env TEST_ARGS="-minikube-start-args='--driver=docker --kubernetes-version=v1.19.0' -test.run TestAddons --cleanup=false" make integration
go test -ldflags="-X k8s.io/minikube/pkg/version.version=v1.22.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.22.0-1628974786-12268 -X k8s.io/minikube/pkg/version.gitCommitID="42aff06bf241e4dbba1992aa9b2a642a5f0d082b-dirty" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v5" -v -test.timeout=90m ./test/integration --tags="integration " -minikube-start-args='--driver=docker --kubernetes-version=v1.19.0' -test.run TestAddons --cleanup=false 2>&1 | tee "./out/testout_42aff06bf.txt"
Found 16 cores, limiting parallelism with --test.parallel=9
=== RUN   TestAddons
=== RUN   TestAddons/Setup
    addons_test.go:80: (dbg) Run:  out/minikube start -p addons-20210822125440-3690423 --wait=true --memory=4000 --alsologtostderr --driver=docker --kubernetes-version=v1.19.0 --addons=ingress
    addons_test.go:80: (dbg) Done: out/minikube start -p addons-20210822125440-3690423 --wait=true --memory=4000 --alsologtostderr --driver=docker --kubernetes-version=v1.19.0 --addons=ingress: (2m26.694217216s)
=== RUN   TestAddons/parallel
=== RUN   TestAddons/parallel/Ingress
=== PAUSE TestAddons/parallel/Ingress
=== CONT  TestAddons/parallel/Ingress
    addons_test.go:170: (dbg) Run:  kubectl --context addons-20210822125440-3690423 wait --for=condition=ready --namespace=ingress-nginx pod --selector=app.kubernetes.io/component=controller --timeout=90s
    addons_test.go:177: (dbg) Run:  kubectl --context addons-20210822125440-3690423 replace --force -f testdata/nginx-ingv1.yaml
    addons_test.go:190: (dbg) Run:  kubectl --context addons-20210822125440-3690423 replace --force -f testdata/nginx-pod-svc.yaml
    addons_test.go:195: (dbg) TestAddons/parallel/Ingress: waiting 4m0s for pods matching "run=nginx" in namespace "default" ...
    helpers_test.go:343: "nginx" [921851ca-a270-4adc-9b1a-b859a329b2a0] Pending / Ready:ContainersNotReady (containers with unready status: [nginx]) / ContainersReady:ContainersNotReady (containers with unready status: [nginx])
    helpers_test.go:343: "nginx" [921851ca-a270-4adc-9b1a-b859a329b2a0] Running
    addons_test.go:195: (dbg) TestAddons/parallel/Ingress: run=nginx healthy within 13.018783465s
    addons_test.go:215: (dbg) Run:  out/minikube -p addons-20210822125440-3690423 ssh "curl -s http://127.0.0.1/ -H 'Host: nginx.example.com'"
    addons_test.go:234: (dbg) Run:  out/minikube -p addons-20210822125440-3690423 addons disable ingress --alsologtostderr -v=1
    addons_test.go:234: (dbg) Done: out/minikube -p addons-20210822125440-3690423 addons disable ingress --alsologtostderr -v=1: (28.676139908s)
=== CONT  TestAddons
    helpers_test.go:184: skipping cleanup of addons-20210822125440-3690423 (--cleanup=false)
--- PASS: TestAddons (189.59s)
    --- PASS: TestAddons/Setup (146.75s)
    --- PASS: TestAddons/parallel (0.00s)
        --- PASS: TestAddons/parallel/Ingress (42.84s)
PASS
Tests completed in 3m9.590185083s (result code 0)
ok      k8s.io/minikube/test/integration        189.620s

k8s-ci-robot · 2021-08-22T03:20:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prezha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [prezha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

prezha · 2021-08-22T12:24:53Z

/ok-to-test

medyagh · 2021-08-23T01:54:54Z

/retest-this-please

medyagh · 2021-08-23T04:04:28Z

@prezha thank you can u plz also fix the cilium and other addon failure son docker Linux ?

prezha · 2021-08-24T01:32:20Z

@medyagh i've added changes that should also fix the gcpauth and olm as well

medyagh · 2021-08-24T22:56:23Z

@prezha

cilium seems to be the last reaminaing test to be fixed then we can merge

https://storage.googleapis.com/minikube-builds/logs/12325/20171/Docker_Linux_containerd.html#fail_TestNetworkPlugins%2fgroup%2fcilium%2fStart

https://storage.googleapis.com/minikube-builds/logs/12325/20171/Docker_Linux.html#fail_TestNetworkPlugins%2fgroup%2fcilium%2fStart

medyagh · 2021-08-25T03:44:31Z

nice job @prezha test look good, just need to fix lint

prezha · 2021-08-25T08:06:55Z

@prezha

cilium seems to be the last reaminaing test to be fixed then we can merge

https://storage.googleapis.com/minikube-builds/logs/12325/20171/Docker_Linux_containerd.html#fail_TestNetworkPlugins%2fgroup%2fcilium%2fStart

https://storage.googleapis.com/minikube-builds/logs/12325/20171/Docker_Linux.html#fail_TestNetworkPlugins%2fgroup%2fcilium%2fStart

@medyagh sure, cilium is fixed now as well :)

minikube-pr-bot · 2021-08-25T09:28:32Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12325) |
+----------------+----------+---------------------+
| minikube start | 47.2s    | 48.4s               |
| enable ingress | 33.8s    | 32.5s               |
+----------------+----------+---------------------+

Times for minikube start: 48.1s 47.0s 46.3s 47.2s 47.1s
Times for minikube (PR 12325) start: 49.6s 47.8s 46.9s 48.1s 49.7s

Times for minikube ingress: 32.8s 32.3s 31.9s 39.4s 32.4s
Times for minikube (PR 12325) ingress: 31.3s 32.7s 33.2s 32.4s 32.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12325) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 20.9s               |
| enable ingress | 35.2s    | 29.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 12325) start: 21.0s 20.7s 21.2s 20.9s 20.8s
Times for minikube start: 23.1s 21.8s 22.5s 22.3s 23.0s

Times for minikube ingress: 35.0s 36.5s 36.0s 31.0s 37.5s
Times for minikube (PR 12325) ingress: 27.4s 26.9s 28.4s 29.4s 34.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12325) |
+----------------+----------+---------------------+
| minikube start | 38.6s    | 44.0s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.7s 43.8s 30.3s 43.7s 43.7s
Times for minikube (PR 12325) start: 43.4s 45.3s 44.4s 43.5s 43.3s

minikube-pr-bot · 2021-08-25T12:24:27Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_crio	TestNetworkPlugins/group/calico/DNS (gopogh)	5.19 (chart)
Docker_Linux	TestStartStop/group/no-preload/serial/Pause (gopogh)	8.44 (chart)
Docker_Linux_crio_arm64	TestFunctional/parallel/BuildImage (gopogh)	10.07 (chart)
Docker_Linux_docker_arm64	TestAddons/parallel/GCPAuth (gopogh)	14.67 (chart)
Docker_Linux_docker_arm64	TestMultiNode/serial/FreshStart2Nodes (gopogh)	14.67 (chart)
Docker_Linux_docker_arm64	TestAddons/parallel/Ingress (gopogh)	18.67 (chart)
Hyperkit_macOS	TestDebPackageInstall/install_amd64_debian (gopogh)	10/kvm2-driver (chart)
Hyperkit_macOS	TestDebPackageInstall/install_amd64_debian (gopogh)	9/kvm2-driver (chart)
Hyperkit_macOS	TestDebPackageInstall/install_amd64_debian (gopogh)	latest/kvm2-driver (chart)
Hyperkit_macOS	TestDebPackageInstall/install_amd64_debian (gopogh)	sid/kvm2-driver (chart)
Hyperkit_macOS	TestDebPackageInstall/install_amd64_ubuntu (gopogh)	18.04/kvm2-driver (chart)
Hyperkit_macOS	TestDebPackageInstall/install_amd64_ubuntu (gopogh)	20.04/kvm2-driver (chart)
Hyperkit_macOS	TestDebPackageInstall/install_amd64_ubuntu (gopogh)	20.10/kvm2-driver (chart)
Hyperkit_macOS	TestDebPackageInstall/install_amd64_ubuntu (gopogh)	latest/kvm2-driver (chart)
Docker_Windows	TestStartStop/group/newest-cni/serial/SecondStart (gopogh)	20.72 (chart)
Docker_Windows	TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh)	20.72 (chart)
Docker_Windows	TestScheduledStopWindows (gopogh)	21.21 (chart)
Docker_Linux_docker_arm64	TestMultiNode/serial/AddNode (gopogh)	21.33 (chart)
Docker_Linux_docker_arm64	TestMultiNode/serial/StartAfterStop (gopogh)	21.33 (chart)
Docker_Linux_docker_arm64	TestAddons/parallel/CSI (gopogh)	22.67 (chart)
Docker_Linux_crio	TestStartStop/group/no-preload/serial/Stop (gopogh)	24.68 (chart)
Docker_Linux_docker_arm64	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	25.33 (chart)
Docker_Linux_docker_arm64	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh)	27.50 (chart)
Docker_Linux_crio	TestStartStop/group/embed-certs/serial/Stop (gopogh)	28.57 (chart)
KVM_Linux_crio	TestJSONOutput/stop/parallel/DistinctCurrentSteps (gopogh)	29.80 (chart)
KVM_Linux_crio	TestJSONOutput/stop/parallel/IncreasingCurrentSteps (gopogh)	29.80 (chart)
Docker_Linux_docker_arm64	TestFunctional/parallel/MountCmd/any-port (gopogh)	32.00 (chart)
Docker_Linux_docker_arm64	TestMultiNode/serial/DeployApp2Nodes (gopogh)	32.00 (chart)
Docker_Linux_docker_arm64	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	32.00 (chart)
Docker_Linux_docker_arm64	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	33.33 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

medyagh · 2021-08-25T17:48:10Z

great work @prezha thank you for all of the work on this PR

sudheerab27 · 2023-05-17T09:50:59Z

@prezha - Can you please share the deploy yaml file for ingress
regarding - #12299

prezha · 2023-05-17T15:18:56Z

@sudheerab27 #12299 was closed almost two years ago - perhaps you wanted to reference something else?

in general, minikube's ingress deployment yaml is based on kind's one:

minikube/deploy/addons/ingress/ingress-deploy.yaml.tmpl

Line 15 in 68180a6

    
           # ref: https://github.com/kubernetes/ingress-nginx/blob/main/deploy/static/provider/kind/deploy.yaml

but it has to be adapted - ie, not a simply full copy&paste
i hope that helps and do let me know if you need any additional help

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 22, 2021

k8s-ci-robot requested review from medyagh and prasadkatti August 22, 2021 03:20

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2021

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 22, 2021

This comment has been minimized.

Sign in to view

prezha changed the title ~~fix ingress for k8s v1.22+~~ fix ingress, gcpauth and olm for k8s v1.22+ Aug 24, 2021

prezha force-pushed the fix-ingress-v1.22 branch from de97041 to f3af986 Compare August 24, 2021 01:45

This comment has been minimized.

Sign in to view

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2021

prezha added 4 commits August 24, 2021 18:05

fix ingress for k8s v1.22+

abd5290

prevent 'assignment to entry in nil map' error.

9c3c5d1

avoid extra newlines around conditions in template

8a510c0

fix gcpauth and olm for k8s v1.22+

7466e4a

prezha force-pushed the fix-ingress-v1.22 branch from f3af986 to 7466e4a Compare August 24, 2021 17:40

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2021

This comment has been minimized.

Sign in to view

fix cilium for k8s v1.22+

aba7d39

This comment has been minimized.

Sign in to view

prezha changed the title ~~fix ingress, gcpauth and olm for k8s v1.22+~~ fix ingress, gcpauth, olm and cilium for k8s v1.22+ Aug 25, 2021

fix lint

1bed766

medyagh changed the title ~~fix ingress, gcpauth, olm and cilium for k8s v1.22+~~ Bump default Kubernetes version to v1.22.1 and update addons to with new API (ingress, gcpauth, olm and cilium) Aug 25, 2021

medyagh merged commit 219580e into kubernetes:master Aug 25, 2021

prezha mentioned this pull request Oct 27, 2021

support k8s < v1.19 & watch-ingress-without-class #12794

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump default Kubernetes version to v1.22.1 and update addons to with new API (ingress, gcpauth, olm and cilium) #12325

Bump default Kubernetes version to v1.22.1 and update addons to with new API (ingress, gcpauth, olm and cilium) #12325

prezha commented Aug 22, 2021 •

edited

Loading

k8s-ci-robot commented Aug 22, 2021

prezha commented Aug 22, 2021

This comment has been minimized.

This comment has been minimized.

medyagh commented Aug 23, 2021

This comment has been minimized.

medyagh commented Aug 23, 2021

This comment has been minimized.

prezha commented Aug 24, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

medyagh commented Aug 24, 2021

This comment has been minimized.

medyagh commented Aug 25, 2021

This comment has been minimized.

prezha commented Aug 25, 2021

minikube-pr-bot commented Aug 25, 2021

minikube-pr-bot commented Aug 25, 2021

medyagh commented Aug 25, 2021

sudheerab27 commented May 17, 2023

prezha commented May 17, 2023

Bump default Kubernetes version to v1.22.1 and update addons to with new API (ingress, gcpauth, olm and cilium) #12325

Bump default Kubernetes version to v1.22.1 and update addons to with new API (ingress, gcpauth, olm and cilium) #12325

Conversation

prezha commented Aug 22, 2021 • edited Loading

changes and notes:

NGINX Ingress Controller (aka ingress-nginx/controller)

Kubernetes webhook certificate generator and patcher (aka kube-webhook-certgen)

examples

just-ingress@docker test:

just-ingress@kvm test:

full test (filtered):

simulated backwards compatibility test with k8s v1.19.0 and old deployment (apis) and images for ingress:

k8s-ci-robot commented Aug 22, 2021

prezha commented Aug 22, 2021

This comment has been minimized.

This comment has been minimized.

medyagh commented Aug 23, 2021

This comment has been minimized.

medyagh commented Aug 23, 2021

This comment has been minimized.

prezha commented Aug 24, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

medyagh commented Aug 24, 2021

This comment has been minimized.

medyagh commented Aug 25, 2021

This comment has been minimized.

prezha commented Aug 25, 2021

minikube-pr-bot commented Aug 25, 2021

minikube-pr-bot commented Aug 25, 2021

medyagh commented Aug 25, 2021

sudheerab27 commented May 17, 2023

prezha commented May 17, 2023

prezha commented Aug 22, 2021 •

edited

Loading