Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things to do before the v1 version is released #7398

Closed
8 of 15 tasks
tao12345666333 opened this issue Jul 28, 2021 · 9 comments · Fixed by #7470
Closed
8 of 15 tasks

Things to do before the v1 version is released #7398

tao12345666333 opened this issue Jul 28, 2021 · 9 comments · Fixed by #7470
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Milestone

Comments

@tao12345666333
Copy link
Member

tao12345666333 commented Jul 28, 2021

In order to facilitate our v1 release, we need to list some planned things for follow-up.

Existing issues:

changes

sha256:a7356029dd0c26cc3466bf7a27daec0f4df73aa14ca6c8b871a767022a812c0b": ["v20210530-g6aab4c291"]

docs

release

  • cut a beta release for controller
  • cut a beta release for Helm chart

Code Freeze and Release

After the above issues are solved and the changes merged a code freeze will be in place

  • Cherry pick missing PRs from dev-v1 to main due to the mess @rikatz made on the branches :P -> main...dev-v1
  • Cut a new branch with existing code and call it v0.X -> This is the version to be supported for the next 6 months + k8s clusters v1.16 ~ v1.18
  • Merge the branch dev-v1 into main
  • Merge all the documentation
  • Release
  • Have two weeks of rest

cc @rikatz @strongjz

Please add or modify this content directly.

If others need to review a PR or issue that needs to be reviewed before the v1 version is released, please also add

/remove-kind bug

@tao12345666333 tao12345666333 added the kind/bug Categorizes issue or PR as related to a bug. label Jul 28, 2021
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jul 28, 2021
@k8s-ci-robot
Copy link
Contributor

@tao12345666333: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Jul 28, 2021
@tao12345666333
Copy link
Member Author

/cc @rikatz @strongjz

@rikatz
Copy link
Contributor

rikatz commented Jul 28, 2021

I don't know if we can create a pre-release helm chart the same way we do with releases here in Github.

One like "this is the latest but you need to install it manually"

Is that possible?

@rikatz
Copy link
Contributor

rikatz commented Jul 28, 2021

https://artifacthub.io/docs/topics/annotations/helm/

Maybe we can cut a helm 4.0 pointing to controller v1.0, kubeVersion >=1.19, and the annotation of pre-release

@strongjz thoughts?

@tao12345666333
Copy link
Member Author

As far as I know, it should not work.

Once released, even if it is a pre-release status in GitHub, our helm repo will not distinguish it.

But I'm happy to try it.

@tao12345666333
Copy link
Member Author

I don't know if we can create a pre-release helm chart the same way we do with releases here in Github.

One like "this is the latest but you need to install it manually"

Is that possible?

@rikatz After a quick verification, it can be realized, as long as the version number conforms to this specification. https://semver.org/#spec-item-9

https://github.com/helm/helm/blob/e9e6b07f62e2bb5067afe79782ba3dd85efbd00e/cmd/helm/install.go#L92-L103

➜  helm-demo helm search repo demo        
NAME            CHART VERSION   APP VERSION     DESCRIPTION                
demo/demo       0.1.0           1.16.0          A Helm chart for Kubernetes
➜  helm-demo helm search repo demo --devel
NAME            CHART VERSION   APP VERSION     DESCRIPTION                
demo/demo       0.2.0-alpha     1.17.0-alpha    A Helm chart for Kubernetes

@rikatz rikatz mentioned this issue Aug 9, 2021
3 tasks
@rikatz
Copy link
Contributor

rikatz commented Aug 9, 2021

@kd7lxl see the description as well, added the required cherry picks before merging

@longwuyuan
Copy link
Contributor

longwuyuan commented Aug 14, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants