Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] Example ingress YAML uses v1 but old serviceName/Port for backends #7417

Closed
maybe-sybr opened this issue Aug 3, 2021 · 5 comments
Closed
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@maybe-sybr
Copy link

NGINX Ingress controller version: 1.0.0-beta.1

Kubernetes version (use kubectl version): Not relevant but 1.21+ server

What happened:
Found while attempting to work out if #7410 was actually a bug or my fault. I copied some example YAML from docs/user-guide/basic-usage.md and it appears to have been updated to use apiVersion: v1 but not the new backend YAML spec. It looks like #7362 needs to be ported onto the dev-v1 branch.

Anything else we need to know:

/kind documentation

@maybe-sybr maybe-sybr added the kind/bug Categorizes issue or PR as related to a bug. label Aug 3, 2021
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 3, 2021
@k8s-ci-robot
Copy link
Contributor

@maybe-sybr: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Aug 3, 2021
@kundan2707
Copy link
Contributor

/assign

@strongjz
Copy link
Member

Any update @kundan2707 ? Do you have a PR open for this?

@strongjz
Copy link
Member

I see, there is some confusion, I apologize, the examples in main are pre v1 updates. We are working on getting everything switched over for the ingress-nginx v1 update to support v1 ingress and k8s > 1.19.

We are tracking that here #7398

/close

@k8s-ci-robot
Copy link
Contributor

@strongjz: Closing this issue.

In response to this:

I see, there is some confusion, I apologize, the examples in main are pre v1 updates. We are working on getting everything switched over for the ingress-nginx v1 update to support v1 ingress and k8s > 1.19.

We are tracking that here #7398

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

4 participants