Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Cluster and instance pool section should within IAM additional chapter #306

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Cluster and instance pool section should within IAM additional chapter #306

merged 1 commit into from
Jun 15, 2018

Conversation

simonswine
Copy link
Contributor 

NONE

@jetstack-bot jetstack-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 14, 2018
@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 14, 2018
@simonswine
Copy link
Contributor Author

/cc @MattiasGees missed that

@jetstack-bot
Copy link
Collaborator

@simonswine: GitHub didn't allow me to request PR reviews from the following users: missed, that.

Note that only jetstack members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @MattiasGees missed that

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonswine simonswine added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2018
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot changed the title Cluster and instance pool should within IAM additional Cluster and instance pool section should within IAM additional chapter Jun 14, 2018
@jetstack-bot jetstack-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 14, 2018
@MattiasGees
Copy link
Member

Correct
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2018
@simonswine simonswine merged commit 726f3d7 into jetstack:master Jun 15, 2018
@dippynark dippynark mentioned this pull request Jul 25, 2018
Merged
jetstack-bot added a commit that referenced this pull request Jul 27, 2018
@jetstack-bot
Merge pull request #381 from dippynark/automated-cherry-pick-of-#247-#…
7785524 
…101-#287-#288-#293-#285-#299-#301-#304-#267-#305-#306-#326-#323-#322-#327-#330-#329-#346-#338-#313-#300-#296-#347-#295-#344-#235-#361-#365-#345-#343-#325-#336-#321-#371-#364-#378-origin-release-0.4

Automated cherry pick of #247 #101 #287 #288 #293 #285 #299 #301 #304 #267 #305 #306 #326 #323 #322 #327 #330 #329 #346 #338 #313 #300 #296 #347 #295 #344 #235 #361 #365 #345 #343 #325 #336 #321 #371 #364 #378
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@charlieegan3 charlieegan3 Awaiting requested review from charlieegan3

@MattiasGees MattiasGees Awaiting requested review from MattiasGees

Assignees

@MattiasGees MattiasGees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonswine @jetstack-bot @MattiasGees