Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Fix etcd mount race condition #313

Merged
merged 1 commit into from
Jun 27, 2018

Conversation

dippynark
Copy link
Contributor

@dippynark dippynark commented Jun 18, 2018

What this PR does / why we need it: etcd service units do not wait until dependent volume has been formatted and mounted - this can lead to a race condition and missing data when starting/restarting etcd

Fix etcd mount race condition

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2018
@dippynark
Copy link
Contributor Author

/retest

@dippynark
Copy link
Contributor Author

/test puppet-tarmak-acceptance-centos v1.9

1 similar comment
@dippynark
Copy link
Contributor Author

/test puppet-tarmak-acceptance-centos v1.9

@dippynark
Copy link
Contributor Author

/test puppet-etcd-acceptance-single-node

1 similar comment
@dippynark
Copy link
Contributor Author

/test puppet-etcd-acceptance-single-node

@dippynark
Copy link
Contributor Author

/test puppet-tarmak-acceptance-centos v1.9

@dippynark
Copy link
Contributor Author

/test puppet-etcd-acceptance-single-node

@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2018
@dippynark dippynark force-pushed the fix-etcd-mount-race branch 4 times, most recently from 955da2f to eefa387 Compare June 19, 2018 14:54
@jetstack-bot jetstack-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2018
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2018
@dippynark
Copy link
Contributor Author

/assign @simonswine

@dippynark
Copy link
Contributor Author

/unassign @simonswine

@dippynark
Copy link
Contributor Author

/test puppet-tarmak-acceptance-centos v1.9

@dippynark dippynark force-pushed the fix-etcd-mount-race branch 2 times, most recently from 073e109 to eea02ca Compare June 19, 2018 16:52
@dippynark
Copy link
Contributor Author

/unassign @dippynark

@dippynark
Copy link
Contributor Author

/assign @simonswine

@simonswine simonswine dismissed their stale review June 20, 2018 11:51

Thanks for fixing luke

@simonswine
Copy link
Contributor

/retest

1 similar comment
@dippynark
Copy link
Contributor Author

/retest

@dippynark
Copy link
Contributor Author

/test puppet-etcd-acceptance-three-node

@dippynark dippynark force-pushed the fix-etcd-mount-race branch 7 times, most recently from fbf3f84 to cbe9211 Compare June 21, 2018 17:57
@dippynark
Copy link
Contributor Author

/retest

@dippynark
Copy link
Contributor Author

/retest

1 similar comment
@dippynark
Copy link
Contributor Author

/retest

@simonswine
Copy link
Contributor

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2018
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants