Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for #920 (disable bundle plugin) #1370

Merged
merged 5 commits into from
Mar 15, 2017
Merged

Bugfix for #920 (disable bundle plugin) #1370

merged 5 commits into from
Mar 15, 2017

Conversation

olamy
Copy link
Member

@olamy olamy commented Mar 3, 2017

fix for #920 simply disable bundle plugin as we don't need it here.

Signed-off-by: olivier lamy <olamy@webtide.com>
Signed-off-by: olivier lamy <olamy@webtide.com>
…it for this uber jar #920

Signed-off-by: olivier lamy <olamy@webtide.com>
@joakime
Copy link
Contributor

joakime commented Mar 3, 2017

Wow! looks real comprehensive.
Need some time to digest it.

@olamy
Copy link
Member Author

olamy commented Mar 3, 2017

well if you prefer something easier and only related to this issue, just keep the last commit with the skip=true for the jetty-runner module

@olamy
Copy link
Member Author

olamy commented Mar 8, 2017

@joakime I took the lazy approach and remove commits which generate failure (not sure about investigate so much changes for 9.2.x would make sense...)
So I simply skip the bundle plugin for jetty-runner :-)

@olamy
Copy link
Member Author

olamy commented Mar 8, 2017

well not sure unit test failure is related...

@janbartel janbartel merged commit 0540d7e into jetty:jetty-9.2.x Mar 15, 2017
@janbartel
Copy link
Contributor

Thanks @olamy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants