no main manifest attribute, in jetty-runner-9.2.19.v20160908.jar

[petr-n]

Today I have used latest 9.2.* version - jetty-runner-9.2.19.v20160908.jar and I have got this error:

pene@petr-ThinkPad-T410:~/run$ sudo java -jar -Dabra.basicstorage.home=basicstorage jetty-runner-9.2.19.v20160908.jar --port 80 igate.war
[sudo] heslo pro pene:
no main manifest attribute, in jetty-runner-9.2.19.v20160908.jar

I have seen there is fix for version 9.3.*. Is it possible to merge the fix to version 9.2?

[janbartel]

Bizarre: when I build jetty-9.2.20-SNAPSHOT locally, the Main-Class property is clearly in the MANIFEST.MF file. However, if I download the latest jetty-9.2.20-SNAPSHOT from https://oss.sonatype.org/content/repositories/jetty-snapshots/org/eclipse/jetty/jetty-runner/9.2.20-SNAPSHOT/, it isn't there!

Investigating.

[joakime]

This is still a problem in jetty 9.2.21 release too.

@olamy didn't you do some work on this?

[olamy]

well I remember having a look at the build.
But I didn't really fix it in any branch as 9.2.x is deprecated/obsolete.
let me know I can have a look for sure.

[joakime]

@olamy ah, I seem to remember that too. Do you recall which branch the fix was put into?

[olamy]

might be this one https://github.com/olamy/jetty.project/tree/bug/deploy_osgi_missing (not really sure)
Not sure but it was issue with bundle plugin executed in the wrong phase.

[joakime]

If you want to submit those 2 commits as a PR, they look good. I'll merge em.

[olamy]

sure. I will test again the fix.
I will probably focus only on jetty-runner.

[olamy]

well after having a look at jetty-runner I wonder if this really need to be OSGI.
As it's simply an uber jar so nothing really OSGI style.
WDYT?

[jmcc0nn3ll]

yeah, I don't see why jetty-runner should have anything to do with osgi

[janbartel]

PR #1370 applied