Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing main manifest attribute in jetty-runner.jar #3241

Closed
rmuller opened this issue Jan 6, 2019 · 4 comments
Closed

Missing main manifest attribute in jetty-runner.jar #3241

rmuller opened this issue Jan 6, 2019 · 4 comments
Assignees
@olamy
Labels
Build
Milestone
9.4.x

Comments

@rmuller
Copy link

rmuller commented Jan 6, 2019 •
edited
Loading

Probably a regression? See #920

(downloaded the jar from Maven Central)
@joakime
Copy link
Contributor

joakime commented Jan 7, 2019

For jetty-9.4.x this needs to be fixed (again. geez).

We need some integration testing for this as well.

For Jetty 10.x onwards, see #1905 (you should consider moving to normal jetty-home and jetty-base behaviors.

@joakime joakime added the Build label Jan 7, 2019
@olamy olamy self-assigned this Jan 8, 2019
olamy added a commit that referenced this issue Jan 9, 2019
@olamy
Issue #3241 no Main Class attribute in MANIFEST for jetty-runner
19c4eb1 
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
@olamy
Copy link
Member

olamy commented Jan 10, 2019

fix done with branch (jetty-9.4.x_jetty_runner_no_manifest) 19c4eb1
still IT test TODO

olamy added a commit that referenced this issue Jan 15, 2019
@olamy
Issue #3241 no Main Class attribute in MANIFEST for jetty-runner
1204e3e 
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
@olamy
Copy link
Member

olamy commented Jan 15, 2019

pr #3260

olamy added a commit that referenced this issue Jan 17, 2019
@olamy
Issue #3241 no Main Class attribute in MANIFEST for jetty-runner
9a2d6f3 
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
olamy added a commit that referenced this issue Jan 17, 2019
@olamy
Issue #3241 no Main Class attribute in MANIFEST for jetty-runner
2295849 
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
@olamy olamy added this to the 9.4.x milestone Jan 17, 2019
olamy added a commit that referenced this issue Jan 17, 2019
@olamy
Issue #3241 Jetty runner add missing Main-Class in MANIFEST (#3260)
766e088 
* Issue #3241 no Main Class attribute in MANIFEST for jetty-runner

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
@olamy
Copy link
Member

olamy commented Jan 17, 2019

fixed with 766e088

@olamy olamy closed this as completed Jan 17, 2019
@joakime joakime changed the title no main manifest attribute, in jetty-runner-9.4.14.v20181114.ar Missing main manifest attribute in jetty-runner.jar Feb 15, 2019
frantuma added a commit to swagger-api/swagger-codegen that referenced this issue Mar 30, 2020
@frantuma
update jetty version to address jetty/jetty.project#3241
96c5a53
@frantuma frantuma mentioned this issue Mar 30, 2020
Merged
frantuma added a commit to swagger-api/swagger-codegen that referenced this issue Mar 30, 2020
@frantuma
Merge pull request #10146 from swagger-api/fix-jetty-runner-minimal
839668c 
update jetty version to address jetty/jetty.project#3241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olamy olamy

Labels
Build
Projects
None yet
Milestone
9.4.x
Development

No branches or pull requests
3 participants
@olamy @joakime @rmuller