Issue #3241 Jetty runner add missing Main-Class in MANIFEST #3260
Conversation
olamy
force-pushed
the
jetty-9.4.x_jetty_runner_no_manifest
branch
from
bab79b2
to
1204e3e
Compare
| <javaHome>${java.home}</javaHome> | ||
| <environmentVariables> | ||
| <JAVA_HOME>${java.home}</JAVA_HOME> | ||
| </environmentVariables> |
There was a problem hiding this comment.
OMG, what is going on here??
There was a problem hiding this comment.
just to be sure the forked maven used the current java version
| <pomIncludes> | ||
| <pomInclude>*/pom.xml</pomInclude> | ||
| </pomIncludes> | ||
| <localRepositoryPath>${project.build.directory}/local-repo</localRepositoryPath> |
There was a problem hiding this comment.
What if my local repo path is different? or even on a different drive?
There was a problem hiding this comment.
Wait, this is in ../target/local-repo isn't it?
There was a problem hiding this comment.
it's the repo path for the forked maven invocation :) so don't worry http://maven.apache.org/plugins/maven-invoker-plugin/run-mojo.html#localRepositoryPath
| <pomInclude>*/pom.xml</pomInclude> | ||
| </pomIncludes> | ||
| <localRepositoryPath>${project.build.directory}/local-repo</localRepositoryPath> | ||
| <settingsFile>src/it/settings.xml</settingsFile> |
There was a problem hiding this comment.
ew! i don't understand this one.
There was a problem hiding this comment.
we use a settings file which simply use your local repo as a mirror (so we do not download all the internet again :) )
same configuration as jetty-maven-plugin
olamy
force-pushed
the
jetty-9.4.x_jetty_runner_no_manifest
branch
from
1aee234
to
d9f2c29
Compare
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
olamy
force-pushed
the
jetty-9.4.x_jetty_runner_no_manifest
branch
from
d9f2c29
to
2295849
Compare
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
|
@janbartel @joakime everything cleaned up. Now this pr only concerns the mentioned issue. Once this is merged. I will make a separate pr for cleaning up. |
No description provided.