Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new Elasticsearch Java client for Spring Boot 3 #20001

Merged
merged 11 commits into from
Oct 19, 2022
Merged

Migrate to new Elasticsearch Java client for Spring Boot 3 #20001

merged 11 commits into from
Oct 19, 2022

Conversation

frascu
Copy link
Contributor

@frascu frascu commented Oct 13, 2022

Fixes #19934


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mraible
Copy link
Contributor

mraible commented Oct 14, 2022

@frascu Can you please update your branch from spring-boot-3.0-m4?

@frascu
Copy link
Contributor Author

frascu commented Oct 14, 2022

Updated

@frascu
Copy link
Contributor Author

frascu commented Oct 17, 2022

My last commit is unrelated to ElasticSearch, but I fixed a compile error for @Type.
I found that this annotation has been removed and we can use @JdbcTypeCode.

It's described better here.

@frascu
Copy link
Contributor Author

frascu commented Oct 17, 2022

@mraible @DanielFran since the failed pipelines are not related to Elasticsearch migration, can this pull request be merged?

@mraible
Copy link
Contributor

mraible commented Oct 17, 2022

I'm OK with merging it. Is that OK with you, @mshima?

@mshima
Copy link
Member

mshima commented Oct 17, 2022

I prefer to merge after spring-boot rc1 release which is due in 3 days 20/10.
RC1 should bring the Problem feature, and maybe we can make some backend tests to pass before merging this PR.
Smaller PRs is much easier to review, the generated diff is quite hand.

@mraible unless if you plan to do some development that requires this PR.
So feel free to merge this PR and #20011 too if you want.

@mshima
Copy link
Member

mshima commented Oct 18, 2022

Closing/reopen to create a new merge point

@mshima mshima closed this Oct 18, 2022
@mshima mshima reopened this Oct 18, 2022
@mshima
Copy link
Member

mshima commented Oct 18, 2022

Is this missing reactive implementation?
Or reactive kept the same?

Nevermind looks included.

@mraible
Copy link
Contributor

mraible commented Oct 19, 2022

I'm merging this PR so @frascu can collect a bug bounty for his work here.

@mraible mraible merged commit b9404c0 into jhipster:spring-boot-3.0-m4 Oct 19, 2022
@frascu
Copy link
Contributor Author

frascu commented Oct 19, 2022

@frascu
Copy link
Contributor Author

frascu commented Oct 20, 2022

@DanielFran can you approve?

@DanielFran
Copy link
Member

@frascu approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants