Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from cloud sleuth to micrometer tracing #20011

Merged
merged 3 commits into from
Oct 23, 2022

Conversation

mshima
Copy link
Member

@mshima mshima commented Oct 14, 2022

Closes #20004.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mraible
Copy link
Contributor

mraible commented Oct 14, 2022

It looks like snapshots need to be updated.

@mshima mshima changed the base branch from main to spring-boot-3.0-m4 October 15, 2022 14:08
@mshima mshima force-pushed the skip_ci-micrometer branch from 3c60c5c to 6f197da Compare October 15, 2022 14:09
@mshima
Copy link
Member Author

mshima commented Oct 15, 2022

Micrometer tracing is still a milestone and probably will follow spring boot 3 cycle, rebased against spring 3 branch.
Seems to be some integration with spring-boot-actuator that should be available at 3.0.0-RC1.
Tried to use snapshot, but failed to compile.

@mshima
Copy link
Member Author

mshima commented Oct 21, 2022

It works almost of the box.
It's conflicting with prometheus right now spring-projects/spring-boot#32817 (comment).

@mshima mshima force-pushed the skip_ci-micrometer branch from 6a081b5 to 329911a Compare October 22, 2022 13:59
@mshima
Copy link
Member Author

mshima commented Oct 22, 2022

It's working out of the box after jhipster/jhipster-bom@9bb15eb.

Documentation updated at jhipster/jhipster.github.io#1238.

Tested using:

jhipster --application-type gateway --defaults --cache-provider no
docker compose -f src/main/docker/zipkin.yml up -d
./mvnw -Pdev,webapp,zipkin

Navigate to localhost:8080 and go to http://localhost:9411/ and click RUN QUERY.
Tracing should be shown.

@mshima mshima marked this pull request as ready for review October 22, 2022 14:00
@mshima
Copy link
Member Author

mshima commented Oct 22, 2022

If startup freezes, disable Prometheus at application.yml.

Copy link
Contributor

@mraible mraible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like snapshots need to be updated.

@DanielFran DanielFran merged commit ed01f6c into jhipster:spring-boot-3.0-m4 Oct 23, 2022
@mshima mshima deleted the skip_ci-micrometer branch February 4, 2023 14:27
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from Spring Cloud Sleuth to Micrometer Tracing
3 participants