-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add start to Coursera stuffs #171
Conversation
Only problem left to resolve (that I know of) is that the darn videos aren't rendering properly. |
Here's a preview of the output. I'm also adding this to the render-bookdown.yml so github actions updates it automatically. |
Not bad, seems like a good start. :) I wonder why the videos aren't rendering... |
if it helps we could have these rendered in the leanpub repo - to avoid messing up the bookdown version, although I see that it seems to be ok |
I thought about that but I think it's easier to do it here since we already set up GitHub pages. |
I think I need to add a youtube conversion step so the url is the youtube "watch" url just like we do in leanbuild. |
I might just functionalize this step in leanbuild and then use it here. |
So the watch links make it take forever to load. As in I clicked on the html locally and it still is trying to load. 😱 5 minutes later. |
So I think the solution here is figure out what renders reliably in an html link and just have the converting function do that. |
I've been fighting with these videos and have gotten some really weird renders. It's not clear to me what voodoo bookdown is doing different to get these videos to turn out right. I might just do something kinda hacky to get it work and call it a day. Then if I figure out a more elegant solution later I can come back to it. |
I've tried working with the bookdown render voodoo to just make a duplicate bookdown that doesn't have a TOC but they make it very hard to not have a TOC:
And I don't know enough CSS and Java to have it edit the end product myself. Seems like it should be simple but it is not so far. My attempt of this strategy is on this branch: https://github.com/jhudsl/DaSL_Course_Template_Bookdown/tree/cansavvy/coursera-render-II |
…d with youtub (#175) * Videos still broken * It's not a great solution but it is a solution * Get rid of stray file
Purpose/implementation Section
What changes are being implemented in this Pull Request?
This isn't quite working yet. It doesn't like the footer for some reason and the image file paths aren't what it wants either. Presumably it doesn't like the
leanbuild::set_knitr_image_path()
and I will need to adjustEdit: Nope it wasn't this, it was that the css file I was referencing had file paths that were not relevant because the coursera renders have no TOC.
Describe your approach:
I borrowed a script I wrote for https://github.com/AlexsLemonade/refinebio-examples/blob/staging/scripts/render-notebooks.R
But adapted it to our needs in this repo.
The goal of the two scripts here is to output rendered htmls docs/coursera that can be linked from the github pages in Coursera.
Usage:
All that needs to happen is this command:
This is related to #123