potential fix to copy quizzes to manuscript dir #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cansavvy
approved these changes
Sep 29, 2021
| @@ -237,6 +244,10 @@ bookdown_to_leanpub <- function(path = ".", | |||
| message("Copying bib files") | |||
| } | |||
| copy_bib(path, output_dir = output_dir) | |||
| copy_quizzes(path, output_dir = output_dir) | |||
There was a problem hiding this comment.
Just so its parallel to the others, can we put message first, then function?
|
Look good now? we can make an issue about adding a check for quizzes later |
The checking machinery exists: https://jhudatascience.org/leanbuild/docs/reference/check_quizzes.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What changes are being implemented in this Pull Request?
Modifying the bookdown_to_leanpub code to copy quizzes
What was your approach?
#79
What GitHub issue does your pull request address?
Tell potential reviewers what kind of feedback you are soliciting.