Fix copy_quizzes to use quiz_dir
#82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cansavvy
commented
Sep 29, 2021
| if (length(files) > 0) { | ||
| file.copy(files, file.path(output_dir), overwrite = TRUE) | ||
| fs::file_copy(quizzes, file.path(output_dir, basename(quizzes)), |
There was a problem hiding this comment.
It copies over the files, ditches the directory. Is this what we want, @carriewright11 ?
There was a problem hiding this comment.
yeah I think that makes sense
There was a problem hiding this comment.
ah yes... good point about the directory...
|
Now to see if the checks pass. |
cansavvy
changed the title
quiz_dirmquiz_dir
carriewright11
approved these changes
Sep 29, 2021
| if (length(files) > 0) { | ||
| file.copy(files, file.path(output_dir), overwrite = TRUE) | ||
| fs::file_copy(quizzes, file.path(output_dir, basename(quizzes)), |
There was a problem hiding this comment.
yeah I think that makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What changes are being implemented in this Pull Request?
This is the sequel to #80 because I reviewed it too quickly and it didn't copy the quizzes. :sad:
But now it does. I changed it to take the quiz_dir argument that a user specifies in the
bookdown_to_leanpub()main function so it should inherit whatever that value is. Also added a message for if that directory isn't found.