Add Match.ID column to guarantee unique ID columns for pivot #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the limited number of venues for the current rounds, the AFL has scheduled two matches for the same venue on the same day, which breaks the uniqueness assumption for those value combinations. Adding an ID column to facilitate pivoting fixes the error raised from duplication causing team columns to have vectors of names instead of individual team names.
|
Thanks @cfranklin11! Looks good to me - the older linux checks are failing in the master branch due to an issue with rmarkdown that should be resolved soon so we can ignore them for now (see rstudio/rmarkdown#1831) Can you just add a bullet point to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the limited number of venues for the current rounds, the
AFL has scheduled two matches for the same venue on the same day,
which breaks the uniqueness assumption for those value combinations.
Adding an ID column to facilitate pivoting fixes the error raised
from duplication causing team columns to have vectors of names
instead of individual team names.