Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't find tools::vignetteInfo() on R < 3.6 #1831

Closed
krlmlr opened this issue Jun 1, 2020 · 14 comments · Fixed by #1832
Closed

Can't find tools::vignetteInfo() on R < 3.6 #1831

krlmlr opened this issue Jun 1, 2020 · 14 comments · Fixed by #1832

Comments

@krlmlr
Copy link
Contributor

krlmlr commented Jun 1, 2020

https://github.com/tidyverse/dbplyr/runs/727729099#step:9:30

tools::vignetteInfo() is available as of R 3.6.

@lorenzwalthert
Copy link

Given that {backports} re-implemented vignetteInfo() in r-lib/backports#36, is it worth restoring previous functionality? We could also just use a plain getFromNamespace("vignetteInfo", ns = "tools"), which is what's done in r-lib/backports#36.

@yihui
Copy link
Member

yihui commented Jun 7, 2020

@lorenzwalthert vignetteInfo() is used for a rather trivial feature in html_vignette() (i.e. warn against differences between vignette index entry and title), so I tend not to consider R < 3.6 for this specific feature. Thanks a lot for your suggestion!

@wch
Copy link
Contributor

wch commented Jun 10, 2020

Is a new CRAN release planned any time soon? The reason I ask is that we have several repos which use GitHub Actions and report failing tests because of this issue, and I'm wondering whether we should (A) wait for this to be fixed in the CRAN version of rmarkdown, or (B) modify our workflows to install the dev version of rmarkdown. If there's going to be a release soon, we'll do (A). If not, we'll do (B).

@yihui
Copy link
Member

yihui commented Jun 11, 2020

Since the last released was made only about a week ago, I tend not to make a new release very soon. Normally I wouldn't consider new releases within a month of the last release, but if this problem is too much trouble, I can try to make the next release sooner (but still in one week or two: the main thing that holds me back is rmarkdown's thousands of rev deps to be checked).

So perhaps you'll have to do (B) for a couple of weeks. Sorry!

@hadley
Copy link
Member

hadley commented Jun 11, 2020

Please release as soon as possible; this is breaking a large number of workflows for us.

If you make the smallest patch to fix this problem, you do not need to re-run all the revdeps (especially since CRAN will run them too). If you really do need to run them, you should talk to @jimhester about taking advantage of our cloud revdep tools so that you can run them all in a couple of hours.

@hadley
Copy link
Member

hadley commented Jun 16, 2020

Could we please get an update on the release process?

@yihui
Copy link
Member

yihui commented Jun 16, 2020

@hadley Sorry I was mostly offline in the past few weeks, and my hands have been extremely tightly tied. I'll try my best to make the new release as soon as possible, but as I said above, it would still be in one week or two. Besides, I have an existing CRAN issue about another package sent from BDR that I haven't completely resolved, so I feel very nervous about making any new CRAN releases at this time.

It might actually be easier for me if you tell me which packages are currently broken, and I send pull requests to you add remotes::install_github('rstudio/rmarkdown') to your Travis or GHA configurations instead.

Apologies again for the trouble, and thanks for you patience and understanding!

@jimhester
Copy link
Contributor

jimhester commented Jun 16, 2020

Every R package that uses rmarkdown for vignettes on R < 3.6 is broken.

@hadley
Copy link
Member

hadley commented Jun 16, 2020

If you need help with the release, we can do it.

@yihui
Copy link
Member

yihui commented Jun 17, 2020

@jimhester Yes, I fully acknowledge that every R package that has vignettes with the output format rmarkdown::html_vignette on R < 3.6 is broken. It was my bad that I failed to realize that tools::vignetteInfo() was not exported until R 3.6. It was my bad that I didn't test lower R versions on Travis earlier. I'm extremely sorry for breaking your workflows. Please give me just a few more days to prepare the release. Thank you very much for your patience!

andrie added a commit to rstudio/sortable that referenced this issue Jun 18, 2020
* Update Roxygen to 7.1.0

* Use github actions instead of travis

* Remove Travis build badge and re-render Readme.

* Re-build README.Rmd

* Fix documentation error; update WORDLIST

* Bump version number to 0.4.3

* Fix documentation references to learnr::question()

* Run github actions with R-devel on Linux instead of macOS; Add R-oldrel to matrix.

* Run Github actions on Ubuntu-16.04

* use_github_action_check_full()

* Test on macOS release (instead of latest)

* Add Ubuntu 16-04 with R-devel

* Use dev rmarkdown, to work around a bug in the CRAN version rstudio/rmarkdown#1831

Co-authored-by: runner <runner@Mac-1467.local>
@yihui
Copy link
Member

yihui commented Jun 18, 2020

On CRAN now: https://cran.r-project.org/package=rmarkdown

@wch
Copy link
Contributor

wch commented Jun 18, 2020

Thanks!

@jimhester
Copy link
Contributor

Thanks for doing a off schedule release for this @yihui!

@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants