Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images to blog content #61

Closed
msevestre opened this issue May 22, 2012 · 37 comments
Closed

Add images to blog content #61

msevestre opened this issue May 22, 2012 · 37 comments
Assignees
Milestone

Comments

@msevestre
Copy link
Collaborator

It would be really useful to be able to some images in a blog post (right now only images already available on the server can be used)

As a quick solution:
1 - Add a new feature in the admin to upload/manage an image on the server
2 - Then one could reference the uploaded image using the WYSWYG editor

@jipiboily
Copy link
Owner

Once we have that implemented, it would be great to make the "og:image" FB open graph tag works correctly.

<meta property="og:image" content="image here!"/>

@msevestre
Copy link
Collaborator Author

That would be awesome!
On May 26, 2012 11:28 AM, "Jean-Philippe Boily" <
reply@reply.github.com>
wrote:

Once we have that implemented, it would be great to make the "og:image" FB
open graph tag works correctly.

<meta property="og:image" content="image here!"/>


Reply to this email directly or view it on GitHub:
#61 (comment)

@jipiboily
Copy link
Owner

Until that, at least, we now have open graph tags (issue #57)

@msevestre
Copy link
Collaborator Author

Isn't the picture a required tag?
On May 26, 2012 12:22 PM, "Jean-Philippe Boily" <
reply@reply.github.com>
wrote:

Until that, at least, we now have open graph tags (issue #57)


Reply to this email directly or view it on GitHub:
#61 (comment)

@jipiboily
Copy link
Owner

It is in theory, but it works without it too. Just tested it.

@msevestre
Copy link
Collaborator Author

Ever heard of that?http://redactorjs.com/
jQuery-based WYSIWYG editor with a built in function for loading image (apparently)

@jipiboily
Copy link
Owner

I saw that yesterday. It seems good. It also seems to lack english documentation, clear licensing and code wasn't on Github AFAIK. Definitely could be tested. I wonder if it supports IE7+? I read on Hacker News it supports iPad too.

@jipiboily
Copy link
Owner

Licensing is problematic: http://cl.ly/2a2e2U45180Y1p3t1T3Z

It was MIT and/or GPL yesterday, Creative common today...hum...lost credibility.

@msevestre
Copy link
Collaborator Author

hum that's too bad...

On Tue, May 29, 2012 at 8:39 PM, Jean-Philippe Boily <
reply@reply.github.com

wrote:

Licensing is problematic: http://cl.ly/2a2e2U45180Y1p3t1T3Z


Reply to this email directly or view it on GitHub:
#61 (comment)

@msevestre
Copy link
Collaborator Author

Any idea when that feature might be implemented or how to tackle the subject? I am going to need that soon. I am ok implementing it but we should maybe discuss the best way to do that? What d'ya think?

@jipiboily
Copy link
Owner

Monologue currently use Tinymce but that could be changed if needed.

Here is a post on stackoverflow that makes me think it might work with Tinymce: http://stackoverflow.com/questions/7413635/what-wysiwyg-editor-can-i-use-for-my-rails-3-1-app-with-support-of-image-uploade

That could also be handled with https://www.filepicker.io/, but it is a paid product...

I did a quick search on wysiwyg editors to see if there is something new under the sun, found nothing interesting. Took a look again at RedactorJS to see if license changed, and nope, it didn't.

Sure thing is I would love the images to be uploaded on Amazon S3 if possible, or local based on a configuration.

What's your thoughts on that?

@jipiboily
Copy link
Owner

By the way, I think images should be added in a global image pool, just like Refinery, but maybe simpler for now.

@jipiboily
Copy link
Owner

Maybe that could be interesting too?

https://github.com/PerfectlyNormal/tinymce-rails-imageupload

@jipiboily
Copy link
Owner

I wonder how Mercury Editor could fit in...maybe there is something really slick to do with that? Any ideas? :)

http://jejacks0n.github.com/mercury/
http://railscasts.com/episodes/296-mercury-editor

@jipiboily
Copy link
Owner

Something else that might do what you want: https://github.com/bastiaanterhorst/rich/

That said, I am not a huge fan of ckeditor in general...doing something with Mercury Editor might be the best way to have a nice and clean implementation!

@jipiboily
Copy link
Owner

I must retract, not sure Mercury Editor is the best option for our needs. rich (https://github.com/bastiaanterhorst/rich/) is probably the easiest solution, if it works as advertised! :)

@msevestre
Copy link
Collaborator Author

wow a lot of info right there. I'll check rich out and see if I can make it
work

On Fri, Aug 3, 2012 at 11:39 AM, Jean-Philippe Boily <
reply@reply.github.com

wrote:

I must retract, not sure Mercury Editor is the best option for our needs.
rich (https://github.com/bastiaanterhorst/rich/) is probably the easiest
solution, if it works as advertised! :)


Reply to this email directly or view it on GitHub:
#61 (comment)

@avitus
Copy link
Contributor

avitus commented Aug 23, 2012

+1 for using Rich.

@msevestre
Copy link
Collaborator Author

Well I was planing on looking into that next week...I guess I know now
where to start...;-)
On Aug 23, 2012 2:48 PM, "Andy" notifications@github.com wrote:

+1 for using Rich.


Reply to this email directly or view it on GitHubhttps://github.com//issues/61#issuecomment-7979802.

@jipiboily
Copy link
Owner

Now back from vacations, I will be able to answer quite fast to PR Michael! ;)

@msevestre
Copy link
Collaborator Author

All right I finally have time and will start with that tonight or tomorrow! Cheers!

@jipiboily
Copy link
Owner

Closing this for now, moved that to 0.3 in the roadmap

@jipiboily
Copy link
Owner

Re-opening this for 0.3.

@chalmagean
Copy link
Contributor

I wanna help move this forward cause I need it for my blog. Do you have anything specific in mind about how it should be implemented ?

@jipiboily
Copy link
Owner

More a vague idea: be able to add image, probably change the WYSIWYG with something easier to extend/work with. Keeping code as clean as possible. @msevestre, you have any specifics to add here? Your clients have asked for that feature right?

@mixandgo: I would be please to review any PR :)

@chalmagean
Copy link
Contributor

So the main issue I'm having is sharing the article on social media sites (actually facebook is more picky here) which don't show an image with the article and. The second issue is a way to easily include images in the article to be displayed as in-article images but also as the "main" image in the article list (index.html).

Now the way I see it is pretty simple: use a new uploader model and provide an (multiple)upload field in the post form.

@msevestre
Copy link
Collaborator Author

I see that feature as the big "missing" feature of Monologue.
Once that's implemented, we have almost everything we need to make
Monologue an even more successful blog engine :-)

My two cents on that discussion:
For now my clients are using flickr to put images on their blog post.
1 Upload image on flickr
2- Add an image link to the aforementioned flickr image. Although it's
fairly easy to do, it's not ideal, especially for non tech user

1- I believe we should use another WYSIWYG editor, that integrates the
feature of uploading an image. Having just an uploaded model and some
fields will not be enough, as you need to reference the image somehow in
your blog post (again we need to think about non tech user here)
2 - I really like rich https://github.com/bastiaanterhorst/rich/, but it
relies on Formtastic or Rails Admin to work. I don't see a problem to use
formtastic instead of the code we have in the admin section
3 - I would be ready to help implementing, once we have agreed on a path to
go

Cheers,

On Tue, Jan 29, 2013 at 1:28 PM, Cezar Halmagean
notifications@git.luolix.topwrote:

So the main issue I'm having is sharing the article on social media sites
(actually facebook is more picky here) which don't show an image with the
article and. The second issue is a way to easily include images in the
article to be displayed as in-article images but also as the "main" image
in the article list (index.html).

Now the way I see it is pretty simple: use a new uploader model and
provide an (multiple)upload field in the post form.


Reply to this email directly or view it on GitHubhttps://github.com//issues/61#issuecomment-12832369.

@chalmagean
Copy link
Contributor

CKEditor looks pretty nice, and it can be integrated with rails pretty easily (https://github.com/galetahub/ckeditor).

The uploading from within the editor sounds even better.

@msevestre
Copy link
Collaborator Author

rich is actually using CKEditor under the hood....

On Tue, Jan 29, 2013 at 7:15 PM, Cezar Halmagean
notifications@git.luolix.topwrote:

CKEditor looks pretty nice, and it can be integrated with rails pretty
easily (https://github.com/galetahub/ckeditor).

The uploading from within the editor sounds even better.


Reply to this email directly or view it on GitHubhttps://github.com//issues/61#issuecomment-12848957.

@chalmagean
Copy link
Contributor

I've started a new engine https://github.com/mixandgo/monologue_ckeditor so opinions and contributions are welcome. This doesn't work just yet but I am working on it.

@msevestre
Copy link
Collaborator Author

Cool. I'll check it out
On Feb 4, 2013 5:11 AM, "Cezar Halmagean" notifications@github.com wrote:

I've started a new engine https://github.com/mixandgo/monologue_ckeditorso opinions and contributions are welcome. This doesn't work just yet but I
am working on it.


Reply to this email directly or view it on GitHubhttps://github.com//issues/61#issuecomment-13069432.

@jipiboily
Copy link
Owner

@mixandgo keep us updated when you have a working version for us to test that. Thanks for your work!

@chalmagean
Copy link
Contributor

@jipiboily, @msevestre I've updated both monologue (See Pull Req) and monologue_ckeditor to be able to replace tinymce.

I've only tested the basics and it seems to work fine. I'm gonna try and improve on it as much as possible and please send your suggestions over.

@jipiboily
Copy link
Owner

@msevestre: this is in master, right?

@msevestre
Copy link
Collaborator Author

CKEditor allows easily to extend Monologue to add images. But it adds a dependency on
gem "carrierwave"
gem "mini_magick"
and I am now thinking that it might be better in an extension that would basically just add the few migrations and models required. Otherwise this might also creates friction when using markdown

What's your take on that?

@jipiboily
Copy link
Owner

+1 for extension!

@msevestre
Copy link
Collaborator Author

This is now handled in an extension here
https://github.com/msevestre/monologue_image_upload
This is for now only compatible with the master branch of monologue. I will create a version that is compatible with the 0.3-stable branch as well.
@jipiboily : Would really appreciate, if you could review the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants