Modularizing the content editor #130
Conversation
This should alow to deface the current editor and use a third party one like monologue_ckeditor.
|
I would actually go a step further and replace the old editor with ckeditor
|
|
@msevestre: 👍 I would also prefer to see Tinymce replaced by ckeditor or any other editor that we might want to use for image upload. @mixandgo, are you planning on making image upload working? If yes, I would prefer to have CKEditor directly in Monologue with image uploading feature. What are your thoughts on that? :) /ref: #61 |
|
I have just pushed a branch that does exactly that I have used the work from @mixando and basically put in monologue itself Not sure how to configure ckeditor . I copied the config over but their What do you guys think? On Mon, Feb 11, 2013 at 7:55 PM, Jean-Philippe Boily <
|
|
It might be too much to include it in monologue do to the fact that it generates it's own model and stuff. Some people might prefer it to be lighter, especially if they have say tinymce or other editor in a different place/gem. What I would do is remove tinymce and provide it as an optional gem. Same goes for ckeditor. |
|
That's a good point. On Mon, Feb 11, 2013 at 8:03 PM, Cezar Halmagean
|
|
Not sure if everyone needs the images and if they do, they might not like the ckeditor. |
|
I must admit I like the idea of extracting the editor. We could provide different options, one could be the "official" editor but having the choice of what you include in your app is a great thing. Especially when you mix multiple engines. This was core to Monologue's idea of having the least possible dependencies to ease it's use with other engines. I suffered a year ago using Spree and Refinery together (I know it's easier now :P) and this is how it all started in fact. It looks like the 'ckeditor' gem supports image uploading, have you guys tried that feature? I did not try that gem at all yet; I am in crunch mode right now and barely have time to comment the issues here and answer mails...;) cc'ing some Monologue users to have their inputs on that before we take a decision... /cc @iwada @kwbock @TheEmpty @swalkinshaw @jvortmann @avitus: your inputs would be appreciated here. Would that be a good thing or a bad thing for your use case(s) to extract the editor from Monologue's core and provide different options via gems? PS: here is another editor you could use for yourselves: https://github.com/jipiboily/monologue-markdown. |
|
I am working on making the upload work. I don't have too much free time but I'm working on it. |
|
Image upload seems to work fine, I've just tested it. |
|
Awesome! On Fri, Mar 1, 2013 at 11:55 PM, Cezar Halmagean
|
|
I can push the test app. --- Cezar On 02.03.2013, at 00:59, Michael Sevestre notifications@github.com wrote:
|
|
cool. Let me know where to find it On Sat, Mar 2, 2013 at 12:08 AM, Cezar Halmagean
|
|
I tried to add https://github.com/mixandgo/monologue_ckeditor to a dummy Monologue project that I have locally. I've got a few issues:
I ran: Added that in the Did I miss something? |
|
just to add to what @jipiboily observed, if you paste the Picture's url into the url field, the picture gets displayed, otherwise, http://cl.ly/image/1D2q1i170k1c |
|
Sorry for the slow answer. I don't think extracting the editor would be too useful. I think most people are looking for a relatively simple, easy to install, lightweight blog engine. Given that the editor isn't too much of a differentiating feature, my guess would be that just picking one and sticking with it would be easiest. I've used ckeditor in the past and have been very happy with it. But these days the functionality in all the editors is fairly comparable. My guess is that many people using Monologue are building it into a website for fairly non-technical users who just need the basic functionality. (Just to add: I'm not opposed to extracting the editor, just don't think it would add too much) |
|
Never too late @avitus ;) The more I think to that, I must say that I would prefer to have a default editor that, if possible, would be easily replaceable if necessary. If we finally extract it, I would make sure to have a Monologue installer and it would add to the Gemfile Monologue AND the "default"/official editor. |
|
Sorry for the late reply, can you describe what you're doing so I can try and reproduce your issue ? I'm mostly using upload to server when adding images. EDIT: You can add issues to the https://github.com/mixandgo/monologue_ckeditor repo |
|
I've updated https://github.com/mixandgo/blogtest and tested the upload to server functionality whichi seems to be working, I've also updated the readme. Please use that to test and report bugs so we all have the same setup. |
|
I see you are using carrierwave. I tried with paperclip. All right i try
|
|
Here is what I am suggesting:
In the extension, we could set a new property that would specify where the pictures should be saved on the server @jipiboily @mixandgo @avitus What do you guys think? I can submit a first PR next week doing that |
|
That plan makes sense to me! :) |
|
This is no longer required as CKEditor is now the default editor for monologue. |
This should alow to deface the current editor and use a third party
one like monologue_ckeditor.