Add option to hide clock #146
Conversation
| val isClockDisplayed = settings.getBoolean(getString(R.string.prefs_settings_key_toggle_clock), true) | ||
|
|
||
| if (!isClockDisplayed) { | ||
| home_fragment_time.text = "" |
There was a problem hiding this comment.
Instead of setting the clock and date to an empty string, consider using visibility. In your case it would be
home_fragment_time.visibility = View.INVISIBLE
home_fragmen_date.visibility = View.INVISIBLEand analogously with View.VISIBLE when the time and date shold be displayed.
There was a problem hiding this comment.
I did try this but it didn't seem to work. I will try to investigate further. I agree visibility is the ideal way to handle this.
There was a problem hiding this comment.
Even if I set the visisbility to invisible directly in the xml, the clock still displays. So I'm thinking something else is interfering
There was a problem hiding this comment.
@CubeOfCheese Any luck with this issue?
There was a problem hiding this comment.
I tried to set the visibility and the alpha value as well but it gets reset somehow. Did not find out where exactly.
What works is to set the height to zero:
home_fragment_time.height=0
home_fragment_date.height=0
| val settings = requireContext().getSharedPreferences(getString(R.string.prefs_settings), Context.MODE_PRIVATE) | ||
| val isClockDisplayed = settings.getBoolean(getString(R.string.prefs_settings_key_toggle_clock), false) | ||
| if (isClockDisplayed) { | ||
| home_fragment_time.setOnClickListener { |
There was a problem hiding this comment.
When setting to INVISIBLE (see above), you don't need to check for isClockDisplayed, since the time and date are not visible and therefore the users are unable to interact with it (e.g. clicking on it). You can remove the condition.
| options_fragment_toggle_clock.isChecked = isClockDisplayed | ||
|
|
||
| options_fragment_toggle_clock.setOnCheckedChangeListener { _, checked -> | ||
| val settings = requireContext().getSharedPreferences(getString(R.string.prefs_settings), MODE_PRIVATE) |
There was a problem hiding this comment.
You already have an instance of settings in line 66. You don't need it here anymore.
|
Oh also I do not have translations in the strings.xml files. How would I go about doing that? |
|
@CubeOfCheese I wouldn't worry about it, right now 😄. |
|
@CubeOfCheese as for future pull requests (in any repository), you can resize your screenshots (eg. to 300 px) with the <img src="<your url here>" height="300px" /> |
There was a problem hiding this comment.
@CubeOfCheese these look awesome. please revise based on some of the other review comments (like duplicate vals), and i'll get this another review shortly!
Addresses #81
Adds toggle control in options menu to display/hide the clock and date.
I am pretty new to Android development so all suggestions and advice are welcome.