Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clock): adds different kinds of clocks #186

Merged
merged 6 commits into from
Dec 29, 2023

Conversation

khwolf
Copy link

@khwolf khwolf commented Dec 28, 2023

Resolves: [Feature Request] Different kinds of clock #173

The digital clock is nice, but it might not be the least distractive option for everyone. I have implemented different kinds of clocks you can choose in the options. Currently, besides the standard digital clock, i have implemented the option to show no clock at all, to have an simple analog watch or (my favorite) to display the time in binary format.

Screenshot_20231126_103616x800-fs8
Screenshot_20231126_103602x800-fs8
Screenshot_20231126_103641x800-fs8

Would love to prepare a pull request, but with so many in the pipeline i am not sure where to base it on and prefer to wait until the way forward is clearer for me. For me they do work and i would like to share.

What are your opinions, what can and should be improved?

Should the date be displayed when the clock is hidden?
What about the date with the analog clock? Would you prefer it below the clock or in a different format e.g. just the day on the clock face?

This is (of course) related to the issue #81, could include #65 and might replace pull request #146.

Closes #173 closes #117 closes #81 closes #146

Copy link
Owner

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stunning! 🤩

I made a few tweaks to reduce the amount of state being stored in the classes, but otherwise the only big update I made was to switch from SharedPreferences to proto.

I appreciate that you may have opted for the SharedPref for the sake of compatibility with SlimLauncher, but honestly there has not been any activity on that repo for over a year. At this point I have decided to prioritize maintainability and ease of future development in Unlancher over upstream compatibility with SlimLauncher and I plan to eventually migrate all the SharedPrefs into proto.

@jkuester jkuester changed the title Adds different kinds of clocks feat(clock): adds different kinds of clocks Dec 29, 2023
@jkuester jkuester merged commit 52aa530 into jkuester:master Dec 29, 2023
1 check passed
@khwolf khwolf deleted the DifferentClockTypes branch December 31, 2023 14:00
@CubeOfCheese
Copy link

This is great!

It looks like I'm a little late here as it was recently merged, but I feel like having the analog clock overlapping the date makes it a little harder to parse either of them. I think it would be better to keep the two separated vertically just like the digital and binary options have.

@jkuester
Copy link
Owner

jkuester commented Dec 31, 2023

Thanks for the feedback! The beauty of open source software is that we can change it if we want to! I think it makes sense to gives others a chance to weigh in on it if they want to, so I have logged an issue for discussion:

#203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants