Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log Cell Execution Status #310

Open
jlewi opened this issue Oct 17, 2024 · 0 comments · Fixed by stateful/vscode-runme#1745
Open

Log Cell Execution Status #310

jlewi opened this issue Oct 17, 2024 · 0 comments · Fixed by stateful/vscode-runme#1745

Comments

@jlewi
Copy link
Owner

jlewi commented Oct 17, 2024

We currently don't log cell execution status.
This is useful signal for learning.

The vscode extension has a boolean measuring success
https://github.com/stateful/vscode-runme/blob/90fcc5b60322b4fe34be714ac120a5794004f837/src/extension/kernel.ts#L819
(I suspect this boolean corresponds to the green/red icon that gets attached to a cell execution).

We report cellExecution here
https://github.com/stateful/vscode-runme/blob/90fcc5b60322b4fe34be714ac120a5794004f837/src/extension/kernel.ts#L777
At the start of the execution. If we moved the report to after the cell finished executing we could attach the status of the cell execution.
@jlewi jlewi mentioned this issue Oct 17, 2024
Merged
jlewi added a commit that referenced this issue Oct 17, 2024
@jlewi
Add a field to LogEvent to report cell execution status. (#311)
46f2ad1 
Related to #310
jlewi added a commit to stateful/vscode-runme that referenced this issue Oct 18, 2024
@jlewi
Report cell execution status to Foyle.
2ee1a16 
* This updates the extension to report the status of the cell execution to Foyle when
  reporting execution events.

* This is highly valuable signal for the AI. This will help us from learning from
  broken/invalid commands.

* Fix jlewi/foyle#310
This was referenced Oct 18, 2024
Merged
Open
jlewi added a commit to jlewi/vscode-runme that referenced this issue Oct 24, 2024
@jlewi
Squashed commit of the following:
95d19ca 
stateful#1745
branch: jlewi/fixexecute
Report cell execution status to Foyle.

* This updates the extension to report the status of the cell execution to Foyle when
  reporting execution events.

* This is highly valuable signal for the AI. This will help us from learning from
  broken/invalid commands.

* Fix jlewi/foyle#310
sourishkrout added a commit to stateful/vscode-runme that referenced this issue Oct 25, 2024
@jlewi @sourishkrout
Report cell execution status to Foyle. (#1745)
c1fa5c9 
* This updates the extension to report the status of the cell execution to Foyle when
  reporting execution events.

* This is highly valuable signal for the AI. This will help us from learning from
  broken/invalid commands.

* Fix jlewi/foyle#310

Co-authored-by: Sebastian Tiedtke <sebastiantiedtke@gmail.com>
hotpocket pushed a commit to hotpocket/vscode-runme that referenced this issue Nov 5, 2024
@jlewi @sourishkrout @hotpocket
Report cell execution status to Foyle. (stateful#1745)
9b3a303 
* This updates the extension to report the status of the cell execution to Foyle when
  reporting execution events.

* This is highly valuable signal for the AI. This will help us from learning from
  broken/invalid commands.

* Fix jlewi/foyle#310

Co-authored-by: Sebastian Tiedtke <sebastiantiedtke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Report cell execution status to Foyle. stateful/vscode-runme
1 participant
@jlewi