Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report cell execution status to Foyle. #1745

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Report cell execution status to Foyle. #1745

merged 3 commits into from
Oct 25, 2024

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Oct 18, 2024

  • This updates the extension to report the status of the cell execution to Foyle when reporting execution events.

  • This is highly valuable signal for the AI. This will help us from learning from broken/invalid commands.

  • Fix Log Cell Execution Status jlewi/foyle#310

* This updates the extension to report the status of the cell execution to Foyle when
  reporting execution events.

* This is highly valuable signal for the AI. This will help us from learning from
  broken/invalid commands.

* Fix jlewi/foyle#310
@jlewi jlewi marked this pull request as ready for review October 18, 2024 01:06
@jlewi jlewi requested a review from sourishkrout October 18, 2024 01:06
@jlewi jlewi marked this pull request as draft October 18, 2024 22:30
@jlewi jlewi marked this pull request as ready for review October 19, 2024 00:59
@jlewi
Copy link
Contributor Author

jlewi commented Oct 24, 2024

@sourishkrout this is ready for review.

jlewi added a commit to jlewi/vscode-runme that referenced this pull request Oct 24, 2024
stateful#1745
branch: jlewi/fixexecute
Report cell execution status to Foyle.

* This updates the extension to report the status of the cell execution to Foyle when
  reporting execution events.

* This is highly valuable signal for the AI. This will help us from learning from
  broken/invalid commands.

* Fix jlewi/foyle#310
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@sourishkrout sourishkrout merged commit c1fa5c9 into main Oct 25, 2024
1 check passed
@sourishkrout sourishkrout deleted the jlewi/fixexecute branch October 25, 2024 20:17
hotpocket pushed a commit to hotpocket/vscode-runme that referenced this pull request Nov 5, 2024
* This updates the extension to report the status of the cell execution to Foyle when
  reporting execution events.

* This is highly valuable signal for the AI. This will help us from learning from
  broken/invalid commands.

* Fix jlewi/foyle#310

Co-authored-by: Sebastian Tiedtke <sebastiantiedtke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log Cell Execution Status
2 participants