Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support import of multithreaded/multiprocess profiles #82

Closed
jlfwong opened this issue Jul 1, 2018 · 1 comment
Closed

Support import of multithreaded/multiprocess profiles #82

jlfwong opened this issue Jul 1, 2018 · 1 comment
Labels
feature request

Comments

@jlfwong
Copy link
Owner

jlfwong commented Jul 1, 2018 •
edited
Loading

This will be helpful for supporting both multiprocess/multithread Instruments import (#63) and general trace import (#77)

This is required for #31.

Here's a rough toolbar mockup showing navigation controls between the profiles from different threads/processes.
image
@jlfwong jlfwong mentioned this issue Jul 1, 2018
Closed
@uber-mahyar2
Copy link

Generalizing this as multitrack support would be smart. Coworkers have talked about wanting to add a separate manual span track (like instruments POIs) on top of the normal main thread track.

@jlfwong jlfwong mentioned this issue Aug 5, 2018
Open
@jlfwong jlfwong changed the title Support display of multiple processes/threads Support import of multithreaded/multiprocess profiles Aug 5, 2018
@jlfwong jlfwong added this to the release-1.0.0 milestone Aug 5, 2018
@jlfwong jlfwong mentioned this issue Aug 5, 2018
Closed
@jlfwong jlfwong mentioned this issue Aug 12, 2018
Merged
jlfwong added a commit that referenced this issue Aug 12, 2018
@jlfwong
Add support for profiles w/ multiples processes & threads (#130)
0e2041c 
More broadly, this just supports multiple profiles loaded into the editor in the same time, which supports import from profiles which are multithreaded by importing each thread as a different profile.

For now, the only two file formats that support multiprocess import are Instruments .trace files and speedscope's own file format

In the process of doing this, I refactored the container code considerably and extracted all the dispatch calls into containers rather than them being part of the non-container view code. This is nice because it means that views don't have to be aware of which Flamechart they are or which profile index is being operated upon.

Fixes #66 
Fixes #82 
Fixes #91
jlfwong added a commit that referenced this issue Aug 12, 2018
@jlfwong
Add support for profiles w/ multiples processes & threads (#130)
e404053 
More broadly, this just supports multiple profiles loaded into the editor in the same time, which supports import from profiles which are multithreaded by importing each thread as a different profile.

For now, the only two file formats that support multiprocess import are Instruments .trace files and speedscope's own file format

In the process of doing this, I refactored the container code considerably and extracted all the dispatch calls into containers rather than them being part of the non-container view code. This is nice because it means that views don't have to be aware of which Flamechart they are or which profile index is being operated upon.

Fixes #66
Fixes #82
Fixes #91
@cawong2 cawong2 mentioned this issue May 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlfwong @uber-mahyar2