Better main thread detection during Instruments data import. #91
Comments
jlfwong
added a commit
that referenced
this issue
Aug 12, 2018
More broadly, this just supports multiple profiles loaded into the editor in the same time, which supports import from profiles which are multithreaded by importing each thread as a different profile. For now, the only two file formats that support multiprocess import are Instruments .trace files and speedscope's own file format In the process of doing this, I refactored the container code considerably and extracted all the dispatch calls into containers rather than them being part of the non-container view code. This is nice because it means that views don't have to be aware of which Flamechart they are or which profile index is being operated upon. Fixes #66 Fixes #82 Fixes #91
jlfwong
added a commit
that referenced
this issue
Aug 12, 2018
More broadly, this just supports multiple profiles loaded into the editor in the same time, which supports import from profiles which are multithreaded by importing each thread as a different profile. For now, the only two file formats that support multiprocess import are Instruments .trace files and speedscope's own file format In the process of doing this, I refactored the container code considerably and extracted all the dispatch calls into containers rather than them being part of the non-container view code. This is nice because it means that views don't have to be aware of which Flamechart they are or which profile index is being operated upon. Fixes #66 Fixes #82 Fixes #91
|
@rudro When you drop an instruments trace onto https://www.speedscope.app/, it should now import all threads in all runs. If you get a chance to give it a try, please let me know how it works for you! |
|
Tried this out, works great! Thanks. |
|
@rudro Hey I'm writing a blogpost for the release of speedscope 1.0. Any chance you'd be able to share some information about what you've been using this for? It sounds like you've been using this predominately through Instruements. Is it for iOS profiling? Is speedscope being used at Uber? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For a complex, heavily multi-threaded app, the logic that assumes that the thread with the most samples is the main thread can be mislead.
Sadly, I don't have a concrete suggestion for something better. I notice that main appears to usually be thread id '4', but there has to be something less hacky.
Just wanted to open this issues to start a discussion about this.
The text was updated successfully, but these errors were encountered: