-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a system for theming, use it to implement dark mode #323
Conversation
@evanw whenever you have the chance to try this out, I'm definitely interested in feedback re: contrast & eye strain. |
Thanks so much for working on this! I just tried it out and it looks fantastic. Switching to Speedscope late at night no longer feels like a punch to the eyeballs. A few things:
|
Also remove implicit ordering dependency between GLCanvas and other views. If GLCanvas ended up being last, then it would always clear, erasing everything we drew before we blit to the screen!
a163a25
to
f3e2119
Compare
Just gave this a try. The colors look great now! FWIW I'm seeing Speedscope lag a lot with quite a few copies of this in my console:
The problem went away when I reverted 2a19c36, which is how I tested the colors. This was tested on master after you landed this PR. Not sure if this is due to me building it incorrectly or not. Just wanted to flag this in case it was real and you were about to do a release without catching this issue. |
I get the following on speedscope.app.
|
Rats. Looks like I broke this on retina displays somehow. Will try to fix. |
@evanw @bjorn3 Fixed in 1.12.1, and https://www.speedscope.app/ should be back to functional now on high DPI displays. |
Thanks! It works now. |
Dark mode:
Light mode:
Fixes #220