Create a new release #587
Merged
Create a new release #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aims to fix the issue described in #575. Sorting the file list before creating the folder structure could cause the file indices to be incorrect, leading to problems such as not downloading the correct file or folder. I tested it with a torrent where I encountered this problem and it seems to work properly with this patch. --------- Co-authored-by: Johan van Eck <johveck@gmail.com>
for #129 Some test cases: ``` > regex = /[ \[\]\.·_-]/g > str1='[这是一部中文电影.Movie.With.Chinese.Title.2024.1080p.WEB-DL.HEVC.10bit.DTS5.1.2Audios-Release]' '[这是一部中文电影.Movie.With.Chinese.Title.2024.1080p.WEB-DL.HEVC.10bit.DTS5.1.2Audios-Release]' > str2='English.Movie.2024.1080p.WEB-DL.HEVC.10bit.DTS5.1.2Audios-Release]' 'English.Movie.2024.1080p.WEB-DL.HEVC.10bit.DTS5.1.2Audios-Release]' > search1 = '中文' '中文' > search2 = 'English Movie' 'English Movie' > str1.toLowerCase().replace(regex, '') '这是一部中文电影moviewithchinesetitle20241080pwebdlhevc10bitdts512audiosrelease' > str2.toLowerCase().replace(regex, '') 'englishmovie20241080pwebdlhevc10bitdts512audiosrelease' > search1.toLowerCase().replace(regex, ' ') '中文' > search2.toLowerCase().replace(regex, ' ') 'english movie' > search1.toLowerCase().replace(regex, '') '中文' > search2.toLowerCase().replace(regex, '') 'englishmovie' > str1.toLowerCase().replace(regex, '').includes(search1.toLowerCase().replace(regex,'')) true > str2.toLowerCase().replace(regex, '').includes(search2.toLowerCase().replace(regex,'')) true ``` Also tested locally in my transmission docker that points to the dev version of UI and it's working. Cannot figure out how to get CORS working to just use `npm start` :/ Co-authored-by: Ivan Xiao <me@ivanxiao.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR releases: