Improve the installation process & some minor changes #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of changes to resolve the problems I had with installing this package. Hope you don't mind some refactoring.
First, there's a convention that the prefix of the package has to be the same as the package name, i.e.
dank-mode-
in this case (maybe in the future someone makes a package calleddank-posts
that does something totally different). So I changed the names accordingly. You'll most likely be required to do so anyhow if you submit this to MELPA.This also allows for having one main file
dank-mode.el
, which lists all the dependencies of the package. Which I've also done, so now the package can be installed withstraight.el
, sans this issue. I added a paragraph with a workaround to the README.Also:
dank-mode-prefer-new-reddit
to preferreddit.com
overold.reddit.com
dank-mode-comments-browse-post-link
,dank-mode-comments-browse-post-comments
,dank-mode-posts-browse-post-link-at-point
anddank-mode-posts-browse-post-comments-at-point
to set theeww
argument with the prefix argument. Otherwise the argument is alwaysnil
.