-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate warning when local repository names are in conflict #500
Comments
Points user to resolution when local repo names are in conflict. Fixes radian-software#500
Points user to resolution when local repo names are in conflict. Fixes #500 Co-authored-by: Radon Rosborough <radon.neon@gmail.com>
Huh. So apparently merging that pull request doesn't close this issue, despite GitHub's claims to the contrary. |
Merging in develop doesn't count, it needs to get merged to the default branch AFAIK |
Ah! That would make sense. Thank you for the explanation :) |
My setup is as below: (use-package pdf-tools
...
:straight web-server
...)
(use-package ein
...
:straight (simple-httpd :host github :repo "skeeto/emacs-web-server" :local-repo "simple-httpd")
...) (Also available in yiufung/dot-emacs/init.el#L2879 and yiufung/dot-emacs/init.el#L3795) I delete Under Incidentally,
Did I miss anything obvious? |
Does |
@progfolio No it doesn't, neither for Digged into the function definition, and find that:
It seems to involve cache file |
Try evaluating the following and sharing the results: (cl-remove-if-not
(lambda (package)
(member "web-server" (nth 1 (gethash package straight--build-cache))))
(hash-table-keys straight--recipe-cache)) |
Try both and rebuilt both, still to no avail. |
Sorry, I should have been more clear. I meant for you to evaluate the above code and see if it printed anything to your *Messages* buffer. It should tell us if there are other packages which depend on "web-server". |
You can try this as well: (cl-some
(lambda (package)
(and (member "web-server" (nth 1 (gethash package straight--build-cache)))
package))
(hash-table-keys straight--recipe-cache)) And if it finds a package which depends on "web-server" it should echo it/ print it to Messages. |
ELISP> (cl-some
(lambda (package)
(and (member "web-server" (nth 1 (gethash package straight--build-cache)))
package))
(hash-table-keys straight--recipe-cache))
nil
ELISP> (cl-some
(lambda (package)
(and (member "simple-httpd" (nth 1 (gethash package straight--build-cache)))
package))
(hash-table-keys straight--recipe-cache))
"org-roam-s..."
ELISP> (cl-some
(lambda (package)
(and (member "simple-httpd" (nth 1 (gethash package straight--build-cache)))
package))
(hash-table-keys straight--recipe-cache))
"org-roam-server"
ELISP> (cl-remove-if-not
(lambda (package)
(member "web-server" (nth 1 (gethash package straight--build-cache))))
(hash-table-keys straight--recipe-cache))
nil
ELISP> (cl-remove-if-not
(lambda (package)
(member "simple-httpd" (nth 1 (gethash package straight--build-cache))))
(hash-table-keys straight--recipe-cache))
("org-roam-server" "jupyter" "impatient-mode") |
I'm experiencing what @yiufung was running into. Running @progfolio 's commands, I see |
You may want to open a new issue for this with the full configuration (see |
Currently, if you use two packages from MELPA (or any source) which result in the same auto-generated local repository name (
:local-repo
), e.g.then
straight.el
generates a warningHowever, this is not a very informative warning to the user, because it does not suggest the resolution of the issue, which is to manually specify
:local-repo
for one of the recipes. A better warning should be shown.Related issues:
The text was updated successfully, but these errors were encountered: