Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README for Rust 1.59 strip feature #34

Merged
merged 2 commits into from
Feb 26, 2022
Merged

Update README for Rust 1.59 strip feature #34

merged 2 commits into from
Feb 26, 2022

Conversation

Frago9876543210
Copy link
Contributor

@Frago9876543210 Frago9876543210 commented Jan 13, 2022 •
edited
Loading

this PR closes #33

@Frago9876543210
Copy link
Contributor Author

currently https://doc.rust-lang.org/cargo/reference/profiles.html#strip doesn't work due to fresh rustc release

@Frago9876543210 Frago9876543210 changed the title update README for rust 1.58 changes update README for rust 1.58 changes, close #33 Jan 13, 2022
@memoryruins
Copy link

rustc's -C strip option is in today's 1.58 release, but cargo's configuration will not be available until the next version, stable 1.59, since its stabilization (rust-lang/cargo#10088) and the sync with rust-lang/rust (rust-lang/rust#92567) only merged 9 days ago.

@johnthagen
Copy link
Owner

Thanks @memoryruins. We'll hold off updating the docs here until the 1.59 release then.

yerke
yerke reviewed Jan 18, 2022
View reviewed changes
README.md Outdated

![Minimum Rust: Nightly](https://img.shields.io/badge/Minimum%20Rust%20Version-nightly%201.45.0-orange.svg)
![Minimum Rust: 1.58](https://img.shields.io/badge/Minimum%20Rust%20Version-1.58-brightgreen.svg)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this needs to be 1.59.

@johnthagen johnthagen changed the title update README for rust 1.58 changes, close #33 Update README for Rust 1.59 strip feature Jan 18, 2022
@eliasfloreteng eliasfloreteng mentioned this pull request Jan 23, 2022
Closed
@eliasfloreteng
Copy link

I have created PR #35 that can be merged before release 1.59 (2022-02-24) with info on how to use strip with stable release 1.58 and info about cargo feature in 1.59.

@johnthagen johnthagen mentioned this pull request Jan 25, 2022
Closed
@Frago9876543210
Copy link
Contributor Author

can be merged now

@johnthagen
Copy link
Owner

Blog post: https://blog.rust-lang.org/2022/02/24/Rust-1.59.0.html#creating-stripped-binaries

@johnthagen johnthagen merged commit 75b00ba into johnthagen:master Feb 26, 2022
@johnthagen
Copy link
Owner

Thanks all!

edmorley added a commit to edmorley/min-sized-rust that referenced this pull request Feb 26, 2022
@edmorley
Add strip=true to the repo examples
7e3b275 
Enables strip in the example `Cargo.toml` files in this repository,
per the recommendation now in README after johnthagen#34.

The reminder to `strip` has been removed from the README,
since the examples will now do that automatically.
@edmorley edmorley mentioned this pull request Feb 26, 2022
Merged
johnthagen pushed a commit that referenced this pull request Feb 26, 2022
@edmorley
Add strip=true to the repo examples (#36)
f7e216d 
Enables strip in the example `Cargo.toml` files in this repository,
per the recommendation now in README after #34.

The reminder to `strip` has been removed from the README,
since the examples will now do that automatically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yerke yerke yerke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update strip documentation for upcoming stable Cargo release
5 participants
@Frago9876543210 @memoryruins @johnthagen @eliasfloreteng @yerke