Stabilize the `strip` profile option, now that rustc has stable `-C strip` #10088

joshtriplett · 2021-11-16T23:50:57Z

rust-lang/rust#90058 stabilized -Z strip as -C strip. Stabilize the corresponding Cargo option.

Update the documentation to move it from the unstable reference to the profiles documentation.

Update the tests to account for stabilization.

rust-highfive · 2021-11-16T23:51:00Z

(rust-highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2021-11-17T14:27:11Z

I think tests will need to account for stable/beta rust not being able to do -C strip right now, but otherwise seems reasonable to me.

mkj · 2021-11-29T01:40:52Z

Are none and off the same? The help text doesn't seem clear on that.

src/doc/src/reference/profiles.md

bors · 2021-12-06T19:29:34Z

☔ The latest upstream changes (presumably #10165) made this pull request unmergeable. Please resolve the merge conflicts.

ehuss · 2021-12-14T18:01:00Z

@joshtriplett It looks like this should be ready to go except for the strip_passes_unknown_option_to_rustc test needs to be updated. The cargo-features line needs to be removed, and the output is slightly different now. I might suggest using [..] on that error message just so it doesn't have to match the exact output of rustc. Generally when testing the text output of rustc, we try to make the tests as fuzzy as we can so that small changes in the format of the text doesn't require also updating cargo simultaneously.

…trip` rust-lang/rust#90058 stabilized `-Z strip` as `-C strip`. Stabilize the corresponding Cargo option. Update the documentation to move it from the unstable reference to the profiles documentation. Update the tests to account for stabilization, but make them no-ops on stable/beta for now until rustc 1.58 releases.

joshtriplett · 2021-12-24T07:41:08Z

@ehuss Thanks for the analysis! Done.

src/doc/src/reference/unstable.md

ehuss · 2021-12-28T15:50:47Z

Looks good! I think we're all good with this, but just to double check:

@rfcbot fcp merge

rfcbot · 2021-12-28T15:50:48Z

Team member @ehuss has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

Co-authored-by: Eric Huss <eric@huss.org>

bors · 2022-01-04T17:11:30Z

📌 Commit bd55063 has been approved by ehuss

bors · 2022-01-04T17:11:37Z

⌛ Testing commit bd55063 with merge 3897749...

bors · 2022-01-04T17:59:02Z

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 3897749 to master...

Update cargo 10 commits in fcef61230c3b6213b6b0d233a36ba4ebd1649ec3..358e79fe56fe374649275ca7aebaafd57ade0e8d 2021-12-17 02:30:38 +0000 to 2022-01-04 18:39:45 +0000 - Make rmeta_required no longer depend on whether timing is enabled (rust-lang/cargo#10254) - The first version of pull request template (rust-lang/cargo#10218) - Stabilize the `strip` profile option, now that rustc has stable `-C strip` (rust-lang/cargo#10088) - Update docs for windows ssh-agent. (rust-lang/cargo#10248) - Fix typo: substract -> subtract (rust-lang/cargo#10244) - timings: Fix tick mark alignment (rust-lang/cargo#10239) - Remove unused lifetimes (rust-lang/cargo#10238) - Make levenshtein distance case insensitive. (rust-lang/cargo#10224) - [docs] Adds basic CI yaml for GitHub Actions (rust-lang/cargo#10212) - Add function for parsing already-read manifest (rust-lang/cargo#10209)

This feature should be stable in 1.58 rust-lang/cargo#10088

Pkgsrc changes: * Bump available bootstraps to 1.58.1. * Adjust one patch (and checksum) so that it still applies. Upstream changes: Version 1.59.0 (2022-02-24) ========================== Language -------- - [Stabilize default arguments for const generics][90207] - [Stabilize destructuring assignment][90521] - [Relax private in public lint on generic bounds and where clauses of trait impls][90586] - [Stabilize asm! and global_asm! for x86, x86_64, ARM, Aarch64, and RISC-V][91728] Compiler -------- - [Stabilize new symbol mangling format, leaving it opt-in (-Csymbol-mangling-version=v0)][90128] - [Emit LLVM optimization remarks when enabled with `-Cremark`][90833] - [Fix sparc64 ABI for aggregates with floating point members][91003] - [Warn when a `#[test]`-like built-in attribute macro is present multiple times.][91172] - [Add support for riscv64gc-unknown-freebsd][91284] - [Stabilize `-Z emit-future-incompat` as `--json future-incompat`][91535] - [Soft disable incremental compilation][94124] This release disables incremental compilation, unless the user has explicitly opted in via the newly added RUSTC_FORCE_INCREMENTAL=1 environment variable. This is due to a known and relatively frequently occurring bug in incremental compilation, which causes builds to issue internal compiler errors. This particular bug is already fixed on nightly, but that fix has not yet rolled out to stable and is deemed too risky for a direct stable backport. As always, we encourage users to test with nightly and report bugs so that we can track failures and fix issues earlier. See [94124] for more details. [94124]: rust-lang/rust#94124 Libraries --------- - [Remove unnecessary bounds for some Hash{Map,Set} methods][91593] Stabilized APIs --------------- - [`std::thread::available_parallelism`][available_parallelism] - [`Result::copied`][result-copied] - [`Result::cloned`][result-cloned] - [`arch::asm!`][asm] - [`arch::global_asm!`][global_asm] - [`ops::ControlFlow::is_break`][is_break] - [`ops::ControlFlow::is_continue`][is_continue] - [`TryFrom<char> for u8`][try_from_char_u8] - [`char::TryFromCharError`][try_from_char_err] implementing `Clone`, `Debug`, `Display`, `PartialEq`, `Copy`, `Eq`, `Error` - [`iter::zip`][zip] - [`NonZeroU8::is_power_of_two`][is_power_of_two8] - [`NonZeroU16::is_power_of_two`][is_power_of_two16] - [`NonZeroU32::is_power_of_two`][is_power_of_two32] - [`NonZeroU64::is_power_of_two`][is_power_of_two64] - [`NonZeroU128::is_power_of_two`][is_power_of_two128] - [`DoubleEndedIterator for ToLowercase`][lowercase] - [`DoubleEndedIterator for ToUppercase`][uppercase] - [`TryFrom<&mut [T]> for [T; N]`][tryfrom_ref_arr] - [`UnwindSafe for Once`][unwindsafe_once] - [`RefUnwindSafe for Once`][refunwindsafe_once] - [armv8 neon intrinsics for aarch64][stdarch/1266] Const-stable: - [`mem::MaybeUninit::as_ptr`][muninit_ptr] - [`mem::MaybeUninit::assume_init`][muninit_init] - [`mem::MaybeUninit::assume_init_ref`][muninit_init_ref] - [`ffi::CStr::from_bytes_with_nul_unchecked`][cstr_from_bytes] Cargo ----- - [Stabilize the `strip` profile option][cargo/10088] - [Stabilize future-incompat-report][cargo/10165] - [Support abbreviating `--release` as `-r`][cargo/10133] - [Support `term.quiet` configuration][cargo/10152] - [Remove `--host` from cargo {publish,search,login}][cargo/10145] Compatibility Notes ------------------- - [Refactor weak symbols in std::sys::unix][90846] This may add new, versioned, symbols when building with a newer glibc, as the standard library uses weak linkage rather than dynamically attempting to load certain symbols at runtime. - [Deprecate crate_type and crate_name nested inside `#![cfg_attr]`][83744] This adds a future compatibility lint to supporting the use of cfg_attr wrapping either crate_type or crate_name specification within Rust files; it is recommended that users migrate to setting the equivalent command line flags. - [Remove effect of `#[no_link]` attribute on name resolution][92034] This may expose new names, leading to conflicts with preexisting names in a given namespace and a compilation failure. - [Cargo will document libraries before binaries.][cargo/10172] - [Respect doc=false in dependencies, not just the root crate][cargo/10201] - [Weaken guarantee around advancing underlying iterators in zip][83791] - [Make split_inclusive() on an empty slice yield an empty output][89825] - [Update std::env::temp_dir to use GetTempPath2 on Windows when available.][89999] - [unreachable! was updated to match other formatting macro behavior on Rust 2021][92137] Internal Changes ---------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Fix many cases of normalization-related ICEs][91255] - [Replace dominators algorithm with simple Lengauer-Tarjan][85013] - [Store liveness in interval sets for region inference][90637] - [Remove `in_band_lifetimes` from the compiler and standard library, in preparation for removing this unstable feature.][91867] [91867]: rust-lang/rust#91867 [83744]: rust-lang/rust#83744 [83791]: rust-lang/rust#83791 [85013]: rust-lang/rust#85013 [89825]: rust-lang/rust#89825 [89999]: rust-lang/rust#89999 [90128]: rust-lang/rust#90128 [90207]: rust-lang/rust#90207 [90521]: rust-lang/rust#90521 [90586]: rust-lang/rust#90586 [90637]: rust-lang/rust#90637 [90833]: rust-lang/rust#90833 [90846]: rust-lang/rust#90846 [91003]: rust-lang/rust#91003 [91172]: rust-lang/rust#91172 [91255]: rust-lang/rust#91255 [91284]: rust-lang/rust#91284 [91535]: rust-lang/rust#91535 [91593]: rust-lang/rust#91593 [91728]: rust-lang/rust#91728 [91878]: rust-lang/rust#91878 [91896]: rust-lang/rust#91896 [91926]: rust-lang/rust#91926 [91984]: rust-lang/rust#91984 [92020]: rust-lang/rust#92020 [92034]: rust-lang/rust#92034 [92483]: rust-lang/rust#92483 [cargo/10088]: rust-lang/cargo#10088 [cargo/10133]: rust-lang/cargo#10133 [cargo/10145]: rust-lang/cargo#10145 [cargo/10152]: rust-lang/cargo#10152 [cargo/10165]: rust-lang/cargo#10165 [cargo/10172]: rust-lang/cargo#10172 [cargo/10201]: rust-lang/cargo#10201 [cargo/10269]: rust-lang/cargo#10269 [cstr_from_bytes]: https://doc.rust-lang.org/stable/std/ffi/struct.CStr.html#method.from_bytes_with_nul_unchecked [muninit_ptr]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.as_ptr [muninit_init]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init [muninit_init_ref]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init_ref [unwindsafe_once]: https://doc.rust-lang.org/stable/std/sync/struct.Once.html#impl-UnwindSafe [refunwindsafe_once]: https://doc.rust-lang.org/stable/std/sync/struct.Once.html#impl-RefUnwindSafe [tryfrom_ref_arr]: https://doc.rust-lang.org/stable/std/convert/trait.TryFrom.html#impl-TryFrom%3C%26%27_%20mut%20%5BT%5D%3E [lowercase]: https://doc.rust-lang.org/stable/std/char/struct.ToLowercase.html#impl-DoubleEndedIterator [uppercase]: https://doc.rust-lang.org/stable/std/char/struct.ToUppercase.html#impl-DoubleEndedIterator [try_from_char_err]: https://doc.rust-lang.org/stable/std/char/struct.TryFromCharError.html [available_parallelism]: https://doc.rust-lang.org/stable/std/thread/fn.available_parallelism.html [result-copied]: https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.copied [result-cloned]: https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.cloned [asm]: https://doc.rust-lang.org/stable/core/arch/macro.asm.html [global_asm]: https://doc.rust-lang.org/stable/core/arch/macro.global_asm.html [is_break]: https://doc.rust-lang.org/stable/std/ops/enum.ControlFlow.html#method.is_break [is_continue]: https://doc.rust-lang.org/stable/std/ops/enum.ControlFlow.html#method.is_continue [try_from_char_u8]: https://doc.rust-lang.org/stable/std/primitive.char.html#impl-TryFrom%3Cchar%3E [zip]: https://doc.rust-lang.org/stable/std/iter/fn.zip.html [is_power_of_two8]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU8.html#method.is_power_of_two [is_power_of_two16]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU16.html#method.is_power_of_two [is_power_of_two32]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU32.html#method.is_power_of_two [is_power_of_two64]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU64.html#method.is_power_of_two [is_power_of_two128]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU128.html#method.is_power_of_two [stdarch/1266]: rust-lang/stdarch#1266

Add profile strip to config docs. This information in the docs was missed when stabilizing in #10088.

rust-highfive assigned Eh2406 Nov 16, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2021

joshtriplett force-pushed the stabilize-strip branch from b1554d4 to 149d196 Compare November 17, 2021 00:23

joshtriplett force-pushed the stabilize-strip branch 2 times, most recently from 29d1e44 to f1212b3 Compare November 17, 2021 23:25

ajeetdsouza mentioned this pull request Nov 28, 2021

Tracking issue for -Z strip=val option rust-lang/rust#72110

Closed

alexcrichton reviewed Nov 29, 2021

View reviewed changes

src/doc/src/reference/profiles.md Show resolved Hide resolved

06kellyjac mentioned this pull request Dec 9, 2021

optimize release build for size serokell/deploy-rs#111

Merged

This was referenced Dec 19, 2021

Update strip documentation for upcoming stable Cargo release johnthagen/min-sized-rust#33

Closed

Mention built-in strip functionality in Cargo? guedou/cargo-strip#10

Closed

joshtriplett force-pushed the stabilize-strip branch from 51cba2b to aff93cd Compare December 24, 2021 07:37

joshtriplett added 2 commits December 23, 2021 23:40

Link to rustc documentation for -C strip

0d02860

joshtriplett force-pushed the stabilize-strip branch from aff93cd to 0d02860 Compare December 24, 2021 07:40

ajeetdsouza mentioned this pull request Dec 24, 2021

Bye bye upx sorry nushell/nushell#4173

Merged

ehuss reviewed Dec 28, 2021

View reviewed changes

src/doc/src/reference/unstable.md Outdated Show resolved Hide resolved

ehuss added the T-cargo Team: Cargo label Dec 28, 2021

rfcbot added proposed-final-comment-period An FCP proposal has started, but not yet signed off. disposition-merge FCP with intent to merge labels Dec 28, 2021

Update stabilization date for strip option

bd55063

Co-authored-by: Eric Huss <eric@huss.org>

joshtriplett added the relnotes Release-note worthy label Dec 28, 2021

rfcbot added the final-comment-period FCP — a period for last comments before action is taken label Dec 29, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2022

bors merged commit 3897749 into rust-lang:master Jan 4, 2022

bors mentioned this pull request Jan 4, 2022

feat: support rustflags per profile #10217

Merged

ehuss mentioned this pull request Jan 5, 2022

Update cargo rust-lang/rust#92567

Merged

Dengjianping mentioned this pull request Jan 5, 2022

Remove strip operation in CI Manta-Network/Manta#325

Closed

joshtriplett deleted the stabilize-strip branch January 5, 2022 17:52

rfcbot added finished-final-comment-period FCP complete to-announce and removed final-comment-period FCP — a period for last comments before action is taken labels Jan 8, 2022

AustinWise added a commit to AustinWise/smeagol that referenced this pull request Jan 12, 2022

Try using cargo's built-in stripping feature.

d9c5dde

This feature should be stable in 1.58 rust-lang/cargo#10088

memoryruins mentioned this pull request Jan 13, 2022

Update README for Rust 1.59 strip feature johnthagen/min-sized-rust#34

Merged

Urgau mentioned this pull request Jan 13, 2022

Stabilize -Z strip as -C strip rust-lang/rust#90058

Merged

AustinWise mentioned this pull request Jan 17, 2022

Strip linux binaries when releasing AustinWise/smeagol#15

Closed

AustinWise added a commit to AustinWise/smeagol that referenced this pull request Jan 17, 2022

Try using cargo's built-in stripping feature.

1562a8f

This feature should be stable in 1.58 rust-lang/cargo#10088

AustinWise added a commit to AustinWise/smeagol that referenced this pull request Jan 17, 2022

Try using cargo's built-in stripping feature.

13bb0f5

This feature should be stable in 1.58 rust-lang/cargo#10088

Y0ba mentioned this pull request Jan 22, 2022

Strip symbols in release mode shadowsocks/shadowsocks-rust#750

Merged

ehuss added this to the 1.59.0 milestone Feb 6, 2022

wcampbell0x2a mentioned this pull request Feb 22, 2022

feat: strip release builds rsadsb/adsb_deku#120

Merged

JamesYeoman mentioned this pull request Feb 25, 2022

Use strip functionality in rustc and cargo tauri-apps/tauri#3559

Closed

masan4444 mentioned this pull request Mar 5, 2022

Use cargo profile instead of RUSTFLAGS masan4444/phpup#16

Merged

MiSawa mentioned this pull request Mar 8, 2022

Add --strip flag fornwall/rust-script#36

Closed

ehuss mentioned this pull request Jul 9, 2023

Add profile strip to config docs. #12337

Merged

bors added a commit that referenced this pull request Jul 9, 2023

Auto merge of #12337 - ehuss:config-strip, r=weihanglo

c40a69d

Add profile strip to config docs. This information in the docs was missed when stabilizing in #10088.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize the `strip` profile option, now that rustc has stable `-C strip` #10088

Stabilize the `strip` profile option, now that rustc has stable `-C strip` #10088

joshtriplett commented Nov 16, 2021

rust-highfive commented Nov 16, 2021

alexcrichton commented Nov 17, 2021

mkj commented Nov 29, 2021

bors commented Dec 6, 2021

ehuss commented Dec 14, 2021 •

edited

Loading

joshtriplett commented Dec 24, 2021

ehuss commented Dec 28, 2021

rfcbot commented Dec 28, 2021 •

edited by alexcrichton

Loading

bors commented Jan 4, 2022

bors commented Jan 4, 2022

bors commented Jan 4, 2022

Stabilize the strip profile option, now that rustc has stable -C strip #10088

Stabilize the strip profile option, now that rustc has stable -C strip #10088

Conversation

joshtriplett commented Nov 16, 2021

rust-highfive commented Nov 16, 2021

alexcrichton commented Nov 17, 2021

mkj commented Nov 29, 2021

bors commented Dec 6, 2021

ehuss commented Dec 14, 2021 • edited Loading

joshtriplett commented Dec 24, 2021

ehuss commented Dec 28, 2021

rfcbot commented Dec 28, 2021 • edited by alexcrichton Loading

bors commented Jan 4, 2022

bors commented Jan 4, 2022

bors commented Jan 4, 2022

Stabilize the `strip` profile option, now that rustc has stable `-C strip` #10088

Stabilize the `strip` profile option, now that rustc has stable `-C strip` #10088

ehuss commented Dec 14, 2021 •

edited

Loading

rfcbot commented Dec 28, 2021 •

edited by alexcrichton

Loading