Stabilize future-incompat-report #10165

Aaron1011 · 2021-12-04T20:18:48Z

Depends on rust-lang/rust#91535

rust-highfive · 2021-12-04T20:18:51Z

r? @ehuss

(rust-highfive has picked a reviewer for you, use r? to override)

src/cargo/core/compiler/mod.rs

ehuss · 2021-12-05T17:14:23Z

Thanks!

Can you update the documentation? What I can see:

Remove this section from unstable.md, and create a ### future incompat report at the bottom of the page in the form of the other stabilized features.
- And remove this line at the top.
Add a cargo report man page:
- Add a page to https://github.com/rust-lang/cargo/tree/master/src/doc/man in the same form as the other pages. This is the first command with subcommands (I think), so we're treading new ground here. But I think just having one man page with a section for each subcommand would be fine (and there's only one subcommand right now).
- Add the page to https://github.com/rust-lang/cargo/blob/master/src/doc/src/SUMMARY.md. Probably to the "build commands". The categorization of commands unfortunately isn't great.
- Add the page to https://github.com/rust-lang/cargo/blob/master/src/doc/src/commands/build-commands.md
Add documentation to every command that takes --future-incompat-report:
- Document it once in a file added to https://github.com/rust-lang/cargo/tree/master/src/doc/man/includes. I would probably provide a short description, and then link to the cargo-report man page for more details.
- In each command, reference that file with {{> options-future-incompat }} which I think should go in the "Display Options" section probably?

Instructions to rebuild the man pages are at https://github.com/rust-lang/cargo/tree/master/src/doc/. More documentation on the man page templates is at https://github.com/rust-lang/cargo/blob/master/crates/mdman/doc/out/mdman.md.

Depends on rust-lang/rust#91535

Aaron1011 · 2021-12-05T20:28:12Z

@ehuss I've updated the docs - let me know if you want any changes.

The nightly tests will begin passing tomorrow, once rust-lang/rust#91535 makes it into a nightly build.

ehuss · 2021-12-06T00:16:15Z

src/doc/man/cargo-report.md

+### DESCRIPTION
+
+Displays a report of the given _type_ - currently, only `future-incompat` is supported
+


Can this include a link to the new future-incompat chapter? IIRC, just a relative link like [foo](../reference/future-incompat-report.html) should.

I added a link in the "See also" section

ehuss · 2021-12-06T00:16:44Z

Looks great!

I forgot that this adds new configuration options. Can you update https://github.com/rust-lang/cargo/blob/master/src/doc/src/reference/config.md to include the new table? It should be included in the example at the top, and then the fields should be documented below (it's alphabetized IIRC). And then add the corresponding environment variables to https://github.com/rust-lang/cargo/blob/master/src/doc/src/reference/environment-variables.md#configuration-environment-variables.

Aaron1011 · 2021-12-06T17:37:32Z

@ehuss: I've added documentation for the new config options (there's no corresponding environment variable). The tests are now passing since the latest nightly supports --json future-incompat.

src/doc/src/reference/config.md

ehuss · 2021-12-06T17:51:20Z

The environment variables are automatically part of the config system, so in this case it is CARGO_FUTURE_INCOMPAT_REPORT_FREQUENCY.

Aaron1011 · 2021-12-06T18:01:32Z

@ehuss Updated

ehuss · 2021-12-06T18:47:33Z

Thanks!!!

@bors r+

bors · 2021-12-06T18:47:34Z

📌 Commit 673b15d has been approved by ehuss

bors · 2021-12-06T18:47:42Z

⌛ Testing commit 673b15d with merge 263b169...

bors · 2021-12-06T19:25:52Z

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 263b169 to master...

Update cargo 8 commits in 294967c53f0c70d598fc54ca189313c86c576ea7..40dc281755137ee804bc9b3b08e782773b726e44 2021-11-29 19:04:22 +0000 to 2021-12-06 21:54:44 +0000 - Unify the description of quiet flag (rust-lang/cargo#10168) - Stabilize future-incompat-report (rust-lang/cargo#10165) - Support abbreviating `--release` as `-r` (rust-lang/cargo#10133) - doc: nudge towards simple version requirements (rust-lang/cargo#10158) - Upgrade clap to 2.34.0 (rust-lang/cargo#10164) - Treat EOPNOTSUPP the same as ENOTSUP when ignoring failed flock calls. (rust-lang/cargo#10157) - Add note about RUSTFLAGS removal from build scripts. (rust-lang/cargo#10141) - Make clippy happy (rust-lang/cargo#10139)

Pkgsrc changes: * Bump available bootstraps to 1.58.1. * Adjust one patch (and checksum) so that it still applies. Upstream changes: Version 1.59.0 (2022-02-24) ========================== Language -------- - [Stabilize default arguments for const generics][90207] - [Stabilize destructuring assignment][90521] - [Relax private in public lint on generic bounds and where clauses of trait impls][90586] - [Stabilize asm! and global_asm! for x86, x86_64, ARM, Aarch64, and RISC-V][91728] Compiler -------- - [Stabilize new symbol mangling format, leaving it opt-in (-Csymbol-mangling-version=v0)][90128] - [Emit LLVM optimization remarks when enabled with `-Cremark`][90833] - [Fix sparc64 ABI for aggregates with floating point members][91003] - [Warn when a `#[test]`-like built-in attribute macro is present multiple times.][91172] - [Add support for riscv64gc-unknown-freebsd][91284] - [Stabilize `-Z emit-future-incompat` as `--json future-incompat`][91535] - [Soft disable incremental compilation][94124] This release disables incremental compilation, unless the user has explicitly opted in via the newly added RUSTC_FORCE_INCREMENTAL=1 environment variable. This is due to a known and relatively frequently occurring bug in incremental compilation, which causes builds to issue internal compiler errors. This particular bug is already fixed on nightly, but that fix has not yet rolled out to stable and is deemed too risky for a direct stable backport. As always, we encourage users to test with nightly and report bugs so that we can track failures and fix issues earlier. See [94124] for more details. [94124]: rust-lang/rust#94124 Libraries --------- - [Remove unnecessary bounds for some Hash{Map,Set} methods][91593] Stabilized APIs --------------- - [`std::thread::available_parallelism`][available_parallelism] - [`Result::copied`][result-copied] - [`Result::cloned`][result-cloned] - [`arch::asm!`][asm] - [`arch::global_asm!`][global_asm] - [`ops::ControlFlow::is_break`][is_break] - [`ops::ControlFlow::is_continue`][is_continue] - [`TryFrom<char> for u8`][try_from_char_u8] - [`char::TryFromCharError`][try_from_char_err] implementing `Clone`, `Debug`, `Display`, `PartialEq`, `Copy`, `Eq`, `Error` - [`iter::zip`][zip] - [`NonZeroU8::is_power_of_two`][is_power_of_two8] - [`NonZeroU16::is_power_of_two`][is_power_of_two16] - [`NonZeroU32::is_power_of_two`][is_power_of_two32] - [`NonZeroU64::is_power_of_two`][is_power_of_two64] - [`NonZeroU128::is_power_of_two`][is_power_of_two128] - [`DoubleEndedIterator for ToLowercase`][lowercase] - [`DoubleEndedIterator for ToUppercase`][uppercase] - [`TryFrom<&mut [T]> for [T; N]`][tryfrom_ref_arr] - [`UnwindSafe for Once`][unwindsafe_once] - [`RefUnwindSafe for Once`][refunwindsafe_once] - [armv8 neon intrinsics for aarch64][stdarch/1266] Const-stable: - [`mem::MaybeUninit::as_ptr`][muninit_ptr] - [`mem::MaybeUninit::assume_init`][muninit_init] - [`mem::MaybeUninit::assume_init_ref`][muninit_init_ref] - [`ffi::CStr::from_bytes_with_nul_unchecked`][cstr_from_bytes] Cargo ----- - [Stabilize the `strip` profile option][cargo/10088] - [Stabilize future-incompat-report][cargo/10165] - [Support abbreviating `--release` as `-r`][cargo/10133] - [Support `term.quiet` configuration][cargo/10152] - [Remove `--host` from cargo {publish,search,login}][cargo/10145] Compatibility Notes ------------------- - [Refactor weak symbols in std::sys::unix][90846] This may add new, versioned, symbols when building with a newer glibc, as the standard library uses weak linkage rather than dynamically attempting to load certain symbols at runtime. - [Deprecate crate_type and crate_name nested inside `#![cfg_attr]`][83744] This adds a future compatibility lint to supporting the use of cfg_attr wrapping either crate_type or crate_name specification within Rust files; it is recommended that users migrate to setting the equivalent command line flags. - [Remove effect of `#[no_link]` attribute on name resolution][92034] This may expose new names, leading to conflicts with preexisting names in a given namespace and a compilation failure. - [Cargo will document libraries before binaries.][cargo/10172] - [Respect doc=false in dependencies, not just the root crate][cargo/10201] - [Weaken guarantee around advancing underlying iterators in zip][83791] - [Make split_inclusive() on an empty slice yield an empty output][89825] - [Update std::env::temp_dir to use GetTempPath2 on Windows when available.][89999] - [unreachable! was updated to match other formatting macro behavior on Rust 2021][92137] Internal Changes ---------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Fix many cases of normalization-related ICEs][91255] - [Replace dominators algorithm with simple Lengauer-Tarjan][85013] - [Store liveness in interval sets for region inference][90637] - [Remove `in_band_lifetimes` from the compiler and standard library, in preparation for removing this unstable feature.][91867] [91867]: rust-lang/rust#91867 [83744]: rust-lang/rust#83744 [83791]: rust-lang/rust#83791 [85013]: rust-lang/rust#85013 [89825]: rust-lang/rust#89825 [89999]: rust-lang/rust#89999 [90128]: rust-lang/rust#90128 [90207]: rust-lang/rust#90207 [90521]: rust-lang/rust#90521 [90586]: rust-lang/rust#90586 [90637]: rust-lang/rust#90637 [90833]: rust-lang/rust#90833 [90846]: rust-lang/rust#90846 [91003]: rust-lang/rust#91003 [91172]: rust-lang/rust#91172 [91255]: rust-lang/rust#91255 [91284]: rust-lang/rust#91284 [91535]: rust-lang/rust#91535 [91593]: rust-lang/rust#91593 [91728]: rust-lang/rust#91728 [91878]: rust-lang/rust#91878 [91896]: rust-lang/rust#91896 [91926]: rust-lang/rust#91926 [91984]: rust-lang/rust#91984 [92020]: rust-lang/rust#92020 [92034]: rust-lang/rust#92034 [92483]: rust-lang/rust#92483 [cargo/10088]: rust-lang/cargo#10088 [cargo/10133]: rust-lang/cargo#10133 [cargo/10145]: rust-lang/cargo#10145 [cargo/10152]: rust-lang/cargo#10152 [cargo/10165]: rust-lang/cargo#10165 [cargo/10172]: rust-lang/cargo#10172 [cargo/10201]: rust-lang/cargo#10201 [cargo/10269]: rust-lang/cargo#10269 [cstr_from_bytes]: https://doc.rust-lang.org/stable/std/ffi/struct.CStr.html#method.from_bytes_with_nul_unchecked [muninit_ptr]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.as_ptr [muninit_init]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init [muninit_init_ref]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init_ref [unwindsafe_once]: https://doc.rust-lang.org/stable/std/sync/struct.Once.html#impl-UnwindSafe [refunwindsafe_once]: https://doc.rust-lang.org/stable/std/sync/struct.Once.html#impl-RefUnwindSafe [tryfrom_ref_arr]: https://doc.rust-lang.org/stable/std/convert/trait.TryFrom.html#impl-TryFrom%3C%26%27_%20mut%20%5BT%5D%3E [lowercase]: https://doc.rust-lang.org/stable/std/char/struct.ToLowercase.html#impl-DoubleEndedIterator [uppercase]: https://doc.rust-lang.org/stable/std/char/struct.ToUppercase.html#impl-DoubleEndedIterator [try_from_char_err]: https://doc.rust-lang.org/stable/std/char/struct.TryFromCharError.html [available_parallelism]: https://doc.rust-lang.org/stable/std/thread/fn.available_parallelism.html [result-copied]: https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.copied [result-cloned]: https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.cloned [asm]: https://doc.rust-lang.org/stable/core/arch/macro.asm.html [global_asm]: https://doc.rust-lang.org/stable/core/arch/macro.global_asm.html [is_break]: https://doc.rust-lang.org/stable/std/ops/enum.ControlFlow.html#method.is_break [is_continue]: https://doc.rust-lang.org/stable/std/ops/enum.ControlFlow.html#method.is_continue [try_from_char_u8]: https://doc.rust-lang.org/stable/std/primitive.char.html#impl-TryFrom%3Cchar%3E [zip]: https://doc.rust-lang.org/stable/std/iter/fn.zip.html [is_power_of_two8]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU8.html#method.is_power_of_two [is_power_of_two16]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU16.html#method.is_power_of_two [is_power_of_two32]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU32.html#method.is_power_of_two [is_power_of_two64]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU64.html#method.is_power_of_two [is_power_of_two128]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU128.html#method.is_power_of_two [stdarch/1266]: rust-lang/stdarch#1266

rust-highfive assigned ehuss Dec 4, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 4, 2021

Aaron1011 mentioned this pull request Dec 4, 2021

Stabilize -Z emit-future-incompat as --json future-incompat rust-lang/rust#91535

Merged

bjorn3 reviewed Dec 5, 2021

View reviewed changes

src/cargo/core/compiler/mod.rs Outdated Show resolved Hide resolved

Aaron1011 added 3 commits December 5, 2021 14:14

Stabilize future-incompat-report

997bf3f

Depends on rust-lang/rust#91535

Detect if rustc supports '--json future-incompat'

c2332dc

Update docs

8c7c35e

Aaron1011 force-pushed the stabilize-future-incompat branch from b3b5837 to 8c7c35e Compare December 5, 2021 20:09

ehuss reviewed Dec 6, 2021

View reviewed changes

Aaron1011 added 2 commits December 6, 2021 10:29

Fix detection of --json future-incompat

365cae3

Improve documentation and add [future-incompat-report] config section

a717196

ehuss reviewed Dec 6, 2021

View reviewed changes

src/doc/src/reference/config.md Outdated Show resolved Hide resolved

src/doc/src/reference/config.md Outdated Show resolved Hide resolved

Aaron1011 added 2 commits December 6, 2021 11:57

Adjust [future-incompat-report] docs

4fcf5ca

Add CARGO_FUTURE_INCOMPAT_REPORT_FREQUENCY to environment variables

673b15d

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2021

bors merged commit 263b169 into rust-lang:master Dec 6, 2021

This was referenced Dec 6, 2021

Allow path = "${FOO}/bar" dependencies #9855

Closed

Stabilize the strip profile option, now that rustc has stable -C strip #10088

Merged

bors mentioned this pull request Dec 6, 2021

Move scrape-examples docs to correct section. #10166

Merged

ehuss mentioned this pull request Dec 7, 2021

Update cargo rust-lang/rust#91619

Merged

ehuss added this to the 1.59.0 milestone Feb 6, 2022

ehuss mentioned this pull request Feb 22, 2022

Tracking Issue for future incompatible report #9241

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize future-incompat-report #10165

Stabilize future-incompat-report #10165

Aaron1011 commented Dec 4, 2021

rust-highfive commented Dec 4, 2021

ehuss commented Dec 5, 2021

Aaron1011 commented Dec 5, 2021

ehuss Dec 6, 2021

Aaron1011 Dec 6, 2021

ehuss commented Dec 6, 2021

Aaron1011 commented Dec 6, 2021

ehuss commented Dec 6, 2021

Aaron1011 commented Dec 6, 2021

ehuss commented Dec 6, 2021

bors commented Dec 6, 2021

bors commented Dec 6, 2021

bors commented Dec 6, 2021

		### DESCRIPTION

		Displays a report of the given _type_ - currently, only `future-incompat` is supported

Stabilize future-incompat-report #10165

Stabilize future-incompat-report #10165

Conversation

Aaron1011 commented Dec 4, 2021

rust-highfive commented Dec 4, 2021

ehuss commented Dec 5, 2021

Aaron1011 commented Dec 5, 2021

ehuss Dec 6, 2021

Choose a reason for hiding this comment

Aaron1011 Dec 6, 2021

Choose a reason for hiding this comment

ehuss commented Dec 6, 2021

Aaron1011 commented Dec 6, 2021

ehuss commented Dec 6, 2021

Aaron1011 commented Dec 6, 2021

ehuss commented Dec 6, 2021

bors commented Dec 6, 2021

bors commented Dec 6, 2021

bors commented Dec 6, 2021