Integrate DIF Resolver #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esolver package of DIF
The mocks / stubs needed an update. The goal was to have the tests pass after the merge.
… test one No API for injecting a custom resolver seems to be present. Will have to be addressed later.
Tests currently fail because of a breaking change in #399. Furthermore, a better API for passing in a custom resolover is needed
chunningham
reviewed
Jun 11, 2020
|
IMHO change this PR to the |
instanceOf assertions can be used again.
…pposed to IRegistry
…ests The change was pushed accidently.
Exulansis
commented
Jun 14, 2020
+1 The next branch is slightly out of date atm. |
Exulansis
added
finished
new feature
|
I've changed the base to We should decide what to do with |
|
Develop should be merged into |
chunningham
approved these changes
Jun 26, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #326
Integrates the DID-Resolver module into our library. Reduces the usage of the
IRegistryinterface, offloading some of the responsibility /complexity to thejolo-did-methodmodule.The API on functions making use of a resolver (e.g.
utils/validation,identityWallet.validateJWT) has been updated to no longer take aIRegistryinstance, but rather take aRegistryclass instead. This is a breaking API change.