Remove quotes from TIG_LS_REMOTE to allow inline shell commands #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The environment variable TIG_LS_REMOTE can be used to select the references that Tig will display. When using a command like TIG_LS_REMOTE='sh -c "a | b"' tig, we pass an argv-array with 3 elements to execvpe. The third argument is passed with quotes, which means that the shell tries to run a command that is literally called 'a | b'. Fix this by removing quotes. We already split arguments with a shell-like syntax, so this only improves compatibility. This makes it easier filter away unwanted refs (jonas#1160) without creating a script TIG_LS_REMOTE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment variable TIG_LS_REMOTE can be used to select the
references that Tig will display.
When using a command like TIG_LS_REMOTE='sh -c "a | b"' tig, we pass an
argv-array with 3 elements to execvpe. The third argument is passed
with quotes, which means that the shell tries to run a command that
is literally called 'a | b'.
Fix this by removing quotes. We already split arguments with a
shell-like syntax, so this only improves compatibility.
This makes it easier filter away unwanted refs (#1160) without creating
a script TIG_LS_REMOTE.