Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes from TIG_LS_REMOTE to allow inline shell commands #1161

Merged
merged 1 commit into from
Nov 11, 2021

Commits on Oct 28, 2021

  1. Remove quotes from TIG_LS_REMOTE to allow inline shell commands

    The environment variable TIG_LS_REMOTE can be used to select the
    references that Tig will display.
    
    When using a command like TIG_LS_REMOTE='sh -c "a | b"' tig, we pass an
    argv-array with 3 elements to execvpe.  The third argument is passed
    with quotes, which means that the shell tries to run a command that
    is literally called 'a | b'.
    
    Fix this by removing quotes. We already split arguments with a
    shell-like syntax, so this only improves compatibility.
    
    This makes it easier filter away unwanted refs (jonas#1160) without creating
    a script TIG_LS_REMOTE.
    krobelus committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    60771ad View commit details
    Browse the repository at this point in the history