Move lang files for search plugin #290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this successful.
I only would suggest to start the name of the class with a upper case letter.
|
astridx
reviewed
Jan 8, 2017
|
@chrisdavenport i have send you a PR: chrisdavenport#1 that reduces the code and use the Joomla API to do that stuff. |
Lets make the script use of even a minimum
|
Thanks @zero-24 |
|
This needs fixing a bug in the build script JoRobo first. (It ignores language files in the plugin folder currently) |
|
@chrisdavenport please fix the merge conflicts and or allow the maintainer edits. Thanks 😄 |
I expect this is done already? |
|
Closing here because there is no update. I have done a new PR with the needed changes #334 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Move language files for the search plugin into the plugin distribution file. This makes all the plugins consistent in not putting language files into administrator/language.
Testing Instructions
Upgrade an existing web links installation and make sure there are no web links language files in administrator/language/en-GB. Make sure language strings for the search plugin are still working.